--TiqCXmo5T1hvSQQg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04/12 11:42, Tal Nisan wrote:
You can see that the hooks is running on that branch it just ignores validation cause it doesn't see it as a stable branch =20 While we're at at it, where can I find the hooks repo? I'd like to write that will check properly for problems in the DB upgrade scripts
The hooks don't do code checks, they must remain lightweight and run on the gerrit host directly, if you want to do any code checks, you can do so in t= he standard ci scripts, that run on jenkins slaves. You can find the code of the hooks here: https://gerrit.ovirt.org/gitweb?p=3Dgerrit-admin.git;a=3Dtree;f=3Dhooks;h= =3D32dbd459456484afcf660bef58303cb66d5a0d75;hb=3DHEAD The specific hooks are under the custom_hooks folder, the lib folder holds utilities to deal with bugzilla and related.
=20 On Tue, Apr 12, 2016 at 11:37 AM, Eyal Edri <eedri@redhat.com> wrote: =20
I also checked the VDSM hooks config, and I think we're missing there validation on target milestone/release, but wasn't sure what to update (lets wait for David to reply).
## Branches to take into account BRANCHES=3D('ovirt-3.6') STABLE_BRANCHES=3D"ovirt-3.6" CHECK_TARGET_RELEASE=3D("ovirt-3.5|^3\.[54321].*") CHECK_TARGET_MILESTONE=3D('ovirt-3.6|^.*3\.6.*')
On Tue, Apr 12, 2016 at 11:31 AM, Eyal Edri <eedri@redhat.com> wrote:
I did some cleanups on the config files and now it only shows the relevant versions (which includes 3.6.5).
## Branches to take into account BRANCHES=3D('ovirt-engine-3.6' 'ovirt-engine-3.6.0' 'ovirt-engine-3.6.= 1' 'ovirt-engine-3.6.2')
STABLE_BRANCHES=3D"ovirt-engine-3.6 ovirt-engine-3.6.5"
CHECK_TARGET_RELEASE=3D("ovirt-engine-3.6|^3\.[6543210].*")
CHECK_TARGET_MILESTONE=3D('ovirt-engine-3.6|^.*3\.6.*')
PRODUCT=3D"oVirt"
I also see on the patch the jobs run:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el7-x86_6= 4/35/ : SUCCESS
http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-fc23-x86_= 64/36/ : SUCCESS
http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el6-x86_6= 4/36/ : SUCCESS
So what is missing?
BTW, David - can we use regex in the stable branch names? I think we c= an enable any 3.6.z branch.
On Mon, Apr 11, 2016 at 3:45 PM, Tal Nisan <tnisan@redhat.com> wrote:
Quite sure we handled this issue but it seems that it's not treated as monitored still: (Taken from https://gerrit.ovirt.org/#/c/55938)
- Check TM::SKIP, not in a monitored branch (ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 ovirt-engine-3.6.2 ovirt-eng= ine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engi= ne-3.5.2 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-eng= ine-3.3.2 ovirt-engine-3.3.1)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --TiqCXmo5T1hvSQQg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXDgTyAAoJEEBxx+HSYmnDT1EH/jtb1aLei5dFF3expFqPztJF 4GKekN7ND3ms7l5NyXOswA2pqFeVVei7Zim89m9OveHDs6Jpg2ZHzlamIVprIjQG zCNWFdjZGDe+Ub8YgCXTqPbs9QI9oDIGEqtEk/joFm+WL6OJSYa4xR/vv0pMQcav IVYerrvsJxW4aJCGsRxrMhUkfMQSjVVs8aXp+jBBTMCqgL8y2Mu/fuzAQDmKJ0Ct Y8IA1pPZx0mzvywplIE5v5Q3lSolLGQMN4h1czGbFElYVa9SKIBb4kKMXLywrVeD aRr6y7itskJadFLAsr4mzokTFXHCRSPo3mKSsBvaUhac77EMXKevEWGcEK+q76g= =ilKK -----END PGP SIGNATURE----- --TiqCXmo5T1hvSQQg--