Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

That was always the case, master maintainers should have +2 on the stable branches without merge rights, this helps me distinguished between: 1. Who is actually a maintainer from the ones acking the patch 2. If a maintainer meant we're good to go or gave his review yet would like another reviewer to have a look On Tue, Dec 20, 2016 at 5:12 PM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > I wasn't aware we were allowing +2 permissions without merge rights on > stable branch, > If this should be supported then we need to update the permissions, so > all master branch maintainers need +2 (w/o merge) to stable branches? > > On Tue, Dec 20, 2016 at 4:58 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: > >> Master >> >> On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri <eedri(a)redhat.com&gt; wrote: >> >>> stable branch maintainers or master branch maintainers? >>> >>> On Dec 20, 2016 4:40 PM, "Tal Nisan" <tnisan(a)redhat.com&gt; wrote: >>> >>>> Heard it from a couple of guys, yesterday it appeared to be working >>>> fine, today it's not >>>> >>>> >>>> _______________________________________________ >>>> Infra mailing list >>>> Infra(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/infra >>>> >>>> >> > > > -- > Eyal Edri > Associate Manager > RHV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 <+972%209-769-2018> > irc: eedri (on #tlv #rhev-dev #rhev-integ) >