[
https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jir...
]
eedri commented on OVIRT-1500:
------------------------------
bq. CI was never triggered for patchset #2. Is this because the only difference between it
and patchset #1 is the commit message?
The current configuration skips any change that doesn't include 'code
change':
"Exclude changes without code change from triggering build
If set, this will ignore any patchset which Gerrit considers without any code changes from
triggering this build. These patches did not contain any differences in code from the
previous patchset and did not change the parent commit.
"
So i'm not sure which inheritance are you reffering to, CI shouldn't run on
patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no?
CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on
gerrit
-------------------------------------------------------------------
Key: OVIRT-1500
URL:
https://ovirt-jira.atlassian.net/browse/OVIRT-1500
Project: oVirt - virtualization made easy
Issue Type: Bug
Components: Gerrit/git, oVirt CI
Reporter: Allon Mureinik
Assignee: infra
In my recent engine patch
https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not
marked as so in gerrit.
Looking through gerrit's history, here's what I *think* is going on:
08:41 - patchset #1 is submitted
08:41 - CI (check-patch) starts for both EL7 and fc25
_At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_
08:42 - patchset #2 is submitted
_CI was never triggered for patchset #2. Is this because the only difference between it
and patchset #1 is the commit message?_
09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not
inherited to patchset #2 for some reason.
Expected behavior:
If CI for patchset #1 passed and the only difference is the commit message (not the
parent commit and not the content), I'd expect the CI score to be inherited.
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)