On Fri, 17 May 2019 at 01:04, Nir Soffer (oVirt JIRA) < jira@ovirt-jira.atlassian.net> wrote:
Nir Soffer commented on OVIRT-2730: -----------------------------------
On Thu, May 16, 2019 at 8:23 AM Barak Korren (oVirt JIRA) <
How do you test this?
I looked at the parameters screen <https://jenkins.ovirt.org/job/standard-manual-runner/265/parameters/> for the refspec you passed to the manual runner (refs/changes/07/100007/8) and then simply checked out the patch with `git review -d 100007`. Looking at `stdci.yaml` there you can see its quite different then the one in the master branch.
But CI is sometimes flaky, and we need to re-trigger a build. Using the command line tool is an easy way.
So is commenting `ci test please` or `ci please test` or just `ci test` in gerrit....
However this was mainly testing the capabilities of the manual runner. I don't think many people will use check-patch from the command line.
Because you can't select substages like that.
Very strange, the patch I tested is was on master which has valid stdci.yaml.
Checkout the patch and have a look, the CI system does not rebase before testing, so it does not matter which branch you intend to merge into, only which commit you started from when first creating the local branch you wrote the patch in.
Here is another check-network build - seems to work correctly:
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
I also did other 2 builds today, and they look normal:
./ovirt-ci run build-artifacts 98608
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
./ovirt-ci run check-patch 98608
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
So running stages seems to work fine.
It runs the exact same code.
Running sub stages using https://jenkins.ovirt.org/job/standard-manual-runner/
------------------------------------------------------------------------------
Key: OVIRT-2730 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2730 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: Nir Soffer Assignee: infra
I tried to run check-patch and check-patch linters substage from the command line: using: https://github.com/nirs/oci/pull/37 I assumed that this will run the entire check-patch stage, including all the sub stages: ./ovirt-ci run -s check-patch 100007 But it run something that looks like check-patch with el7:
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
The test environment seems to be different that what we have when check-patch is triggered from gerrit. Then I tried to run the linters substage: ./ovirt-ci run -s check-patch.linters 100007
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
./ovirt-ci run -s check-patch.linters 100007
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
Both succeeded without running anything :-) Running build-artifacts works, not sure about check-network. Can we fix the manual job so: - it run exactly the same way as it run when gerrit trigger the job - allow selection of a sub stage? - nice to have - allow selection of multiple sub stages Nir
-- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100102) _______________________________________________ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/QBZQG7EHLOFKIO...
-- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted