
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nKx9mgUuOtUVNp59iRo4vCTj1jVX8N277 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Tomas! One of your commits (not sure if 77de5a2fc23e5090934003848ceedcece29ca69= 8 or d19e7776918d0aba6b833c496e05630195609994) introduced a new findbugs error= on ovirt-engine/master, can you take a look please? """ CloneVmCommand.java:214, EC_UNRELATED_TYPES, Priority: High =E7 Call to org.ovirt.engine.core.common.utils.VmDeviceType.equals(String) in= org.ovirt.engine.core.bll.CloneVmCommand.containsDeviceWithType(List, VmDeviceGeneralType, VmDeviceType) This method calls equals(Object) on two references of different class ty= pes with no common subclasses. Therefore, the objects being compared are unli= kely to be members of the same class at runtime (unless some application classes = were not analyzed, or dynamic class loading can occur at runtime). According t= o the contract of equals(), objects of different classes should always compare = as unequal; therefore, according to the contract defined by java.lang.Object.equals(Object), the result of this comparison will alway= s be false at runtime. """ Thanks! --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --nKx9mgUuOtUVNp59iRo4vCTj1jVX8N277 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTRr3AAAoJEEBxx+HSYmnD2D8H/j0KK0gUcUqW910eCfPFK5bS vP0Lod0nI6tjb8+1f6twfCx5jH6SXSmFGwLw6KQES03e9f9shhY379iF43AiNs/a AlGUoHgXYChm8OHaz5/n+xOGk/SqgO1GZpzUqj6jmPqBRKJqg6W8JTX738wevuo7 k5RhkrGrAYCJIwRvcYwc6PndmkUPdwN+9jIsrPNnNLkS3si10lMA7rDFHnXIWmhA d205sys55BGRH1SA0VQOBa6hNzygQb/hlaQTh9eI/Jj+08a9A8AoAx6zJVvrYD/W iEaLKvzCyKFSh2Flc1OiBQCKjWIkBq6c9UGnshhz13gFod3jWZqYv23IDSFFBsk= =R8kx -----END PGP SIGNATURE----- --nKx9mgUuOtUVNp59iRo4vCTj1jVX8N277--