On Tue, Apr 12, 2016 at 11:42 AM, Tal Nisan <tnisan@redhat.com> wrote:
You can see that the hooks is running on that branch it just ignores validation cause it doesn't see it as a stable branch
Can you show example where validation was ignored? FYI, We removed some of the old jobs that were running per patch as their code is part of the code in check-patch.sh already, maybe that's what you refer to?
While we're at at it, where can I find the hooks repo? I'd like to write that will check properly for problems in the DB upgrade scripts
On Tue, Apr 12, 2016 at 11:37 AM, Eyal Edri <eedri@redhat.com> wrote:
I also checked the VDSM hooks config, and I think we're missing there validation on target milestone/release, but wasn't sure what to update (lets wait for David to reply).
## Branches to take into account BRANCHES=('ovirt-3.6') STABLE_BRANCHES="ovirt-3.6" CHECK_TARGET_RELEASE=("ovirt-3.5|^3\.[54321].*") CHECK_TARGET_MILESTONE=('ovirt-3.6|^.*3\.6.*')
On Tue, Apr 12, 2016 at 11:31 AM, Eyal Edri <eedri@redhat.com> wrote:
I did some cleanups on the config files and now it only shows the relevant versions (which includes 3.6.5).
## Branches to take into account BRANCHES=('ovirt-engine-3.6' 'ovirt-engine-3.6.0' 'ovirt-engine-3.6.1' 'ovirt-engine-3.6.2')
STABLE_BRANCHES="ovirt-engine-3.6 ovirt-engine-3.6.5"
CHECK_TARGET_RELEASE=("ovirt-engine-3.6|^3\.[6543210].*")
CHECK_TARGET_MILESTONE=('ovirt-engine-3.6|^.*3\.6.*')
PRODUCT="oVirt"
I also see on the patch the jobs run:
Build Successful
http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el7-x86_64/35/ : SUCCESS
http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-fc23-x86_64/36/ : SUCCESS
http://jenkins.ovirt.org/job/ovirt-engine_3.6.5_check-merged-el6-x86_64/36/ : SUCCESS
So what is missing?
BTW, David - can we use regex in the stable branch names? I think we can enable any 3.6.z branch.
On Mon, Apr 11, 2016 at 3:45 PM, Tal Nisan <tnisan@redhat.com> wrote:
Quite sure we handled this issue but it seems that it's not treated as monitored still: (Taken from https://gerrit.ovirt.org/#/c/55938)
- Check TM::SKIP, not in a monitored branch (ovirt-engine-3.6 ovirt-engine-3.6.0 ovirt-engine-3.6.1 ovirt-engine-3.6.2 ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.5.2 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)