Re: Permissions on stable branches

On 08/26, Tal Nisan wrote: > User id is 10070, I should be able to remove reviewers from patches (mostly > the ci automated users for that matter) I'll need the patch to check it in more detail, that account id is ok. You can override any automated user (CI flag) by just setting it to +1 yourself, that's the preferred way of overriding it as it keeps the automated score and helps us to debug it latter. If you are trying to override another flag, that might be the hooks check, you should not, if they misbehave they should be fixed, so please send us the patch. If it's not the CI flag, and it's not the gerrit-hooks, then there's an issue on some of the jobs, so it still needs debugging, probably disabling the job. cheers > On 08/26/2015 08:00 PM, David Caro wrote: >> I'm not aware of any changes, maybe you got a duplicated account, that's why I >> ask for the account id >> >> On 08/26, Tal Nisan wrote: >>> I can abandon, I cannot remove reviewers and I was able to do so till not long ago >>> >>> On Aug 26, 2015 19:38, David Caro <dcaro(a)redhat.com&gt; wrote: >>>> >>>> I see you in the group that has right to abandon on those branches: >>>> >>>> https://gerrit.ovirt.org/#/admin/groups/63,members >>>> >>>> can you pass me the account id you are using? (on the upper right corner, hit >>>> your name -> settings) >>>> >>>> On 08/26, Tal Nisan wrote: >>>>> ovirt-engine-3.6 >>>>> ovirt-engine-3.5 >>>>> >>>>> On Aug 26, 2015 19:07, David Caro <dcaro(a)redhat.com&gt; wrote: >>>>>> What are your branches? >>>>>> >>>>>> On 08/26, Tal Nisan wrote: >>>>>>> Just noticed that I now don't have the ability to remove reviews in my >>>>>>> branches, can someone have a look why it changed? >>>>>>> >>>>>>> On 08/20/2015 11:34 AM, David Caro wrote: >>>>>>>> On 08/20, Tal Nisan wrote: >>>>>>>>> It seems that I can abandon 3.6 patches now as well, are you sure I need to >>>>>>>>> be on that group? >>>>>>>> Nop, you are right, just missed to see that 6 was included in the regexp: >>>>>>>> >>>>>>>> ^refs/heads/ovirt-engine-3\.[56]([^-].*)?$ >>>>>>>> >>>>>>>>> On 08/20/2015 11:19 AM, David Caro wrote: >>>>>>>>>> On 08/19, Tal Nisan wrote: >>>>>>>>>>> Hi all, >>>>>>>>>>> In order to better manage the branches I maintain (ovirt-engine 3.5 & 3.6) >>>>>>>>>>> I'd like to have permissions to abandon patches and change patch topics, can >>>>>>>>>>> you please give me those? >>>>>>>>>> I've given you those right for 3.5 branch, but on 3.6 you have to be in the >>>>>>>>>> ovirt-engine-abandon group, and I'll need ack from itamar or oved for that: >>>>>>>>>> >>>>>>>>>> https://gerrit.ovirt.org/#/admin/groups/70,members >>>>>>>>>> >>>>>> -- >>>>>> David Caro >>>>>> >>>>>> Red Hat S.L. >>>>>> Continuous Integration Engineer - EMEA ENG Virtualization R&D >>>>>> >>>>>> Tel.: +420 532 294 605 >>>>>> Email: dcaro(a)redhat.com >>>>>> Web: www.redhat.com >>>>>> RHT Global #: 82-62605 >>>> -- >>>> David Caro >>>> >>>> Red Hat S.L. >>>> Continuous Integration Engineer - EMEA ENG Virtualization R&D >>>> >>>> Tel.: +420 532 294 605 >>>> Email: dcaro(a)redhat.com >>>> Web: www.redhat.com >>>> RHT Global #: 82-62605