Re: ovirt-engine-4.0.5 is not treated as a monitored stable branch

Hi, Tal: The '*Check merged to previous*' hook is checking if the current patch was merged to previous stable branches and i think that it is not related to the one that you're searching. Eyal: Currently there is no hook that checks if branch is enabled, but there is hook that checks if the patch major version branch is [equal / higher / lower] than the bug target milestone major version. i'll explain by giving you few examples and their results: Example 1: tm: '---' (empty target milestone) branch major version: any result: *WARN MSG* Example 2: tm major version: 3.6 branch major version: 3.6 result: *OK MSG* Example 3: tm major version: 3.6 branch major version: 4.0 result: checks for clone flags (if tm major version in flags - *OK MSG* else *WARN MSG*) Example 4: tm major version: 4.0 branch major version: 3.6 result: *WARN MSG* Best Regards, Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL RHCSA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1 On Sun, Oct 30, 2016 at 9:45 AM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > Shlomi, > Can you check if we have the hook for verifying right branch is enabled? > > > > On Thu, Oct 27, 2016 at 11:00 AM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: > >> This patch was pushed to 4.0.5 with a bug that at the time of the push >> was 4.1, Gerrit hooks should have marked it as -verified, instead you get: >> >> - Check merged to previous::IGNORE, Not in stable branch >> (['ovirt-engine-3.6', 'ovirt-engine-4.0', 'ovirt-engine-3.6.9', >> 'ovirt-engine-4.0.2', 'ovirt-engine-4.0.4']) >> >> >> On Thu, Oct 27, 2016 at 9:55 AM, Gil Shinar <gshinar(a)redhat.com&gt; wrote: >> >>> Can you please elaborate? >>> >>> Thanks >>> Gil >>> >>> On Wed, Oct 26, 2016 at 11:50 AM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: >>> >>>> This patch for example: >>>> https://gerrit.ovirt.org/#/c/65398/ >>>> >>>> >>>> _______________________________________________ >>>> Infra mailing list >>>> Infra(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/infra >>>> >>>> >>> >> >> _______________________________________________ >> Infra mailing list >> Infra(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/infra >> >> > > > -- > Eyal Edri > Associate Manager > RHV DevOps > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ) >