Re: gerrit: vdsm: grant tag permission to stable branch maintainer

On 08/01, Dan Kenigsberg wrote: > On Thu, Jul 31, 2014 at 04:08:40PM +0200, David Caro wrote: >> On 07/31, ybronhei wrote: >>> On 07/23/2014 06:39 PM, David Caro wrote: >>>> >>>> Can any of you (vdsm maintainers) test if he has rights to push >>>> annotated tags? >>>> >>> Hey dcaro, >>> sorry for the late response.. didn't have nothing to tag. >>> >>> but i still can't.. >>> getting the following: >>> >>> ybronhei@ybronhei:~/Projects/vdsm ((ad88538...))$ git tag -a >>> v4.14.12 ad88538dc77502bc0a5135216f5e3210435cce5b >>> ybronhei@ybronhei:~/Projects/vdsm ((v4.14.12))$ git push origin v4.14.12 >>> Counting objects: 1, done. >>> Writing objects: 100% (1/1), 176 bytes | 0 bytes/s, done. >>> Total 1 (delta 0), reused 0 (delta 0) >>> remote: Processing changes: refs: 1, done >>> To gerrit.ovirt.org:vdsm >>> ! [remote rejected] v4.14.12 -> v4.14.12 (prohibited by Gerrit) >>> error: failed to push some refs to 'gerrit.ovirt.org:vdsm' >> >> Was it an annotated tag? >> $ git tag -am 'My message' v4.14.12 >> $ git push origin v4.14.12 HEAD:refs/heads/master > > Yes, it was anotated; I don't think that your suggested git-push is > valid. Well, that worked for me last time, and it's the suggested way of pushing annotated tags to gerrit. The difference is that you are not specifying which ref you are sending to which other ref, (HEAD:refs/heads/master), so git has to figure out himself that data in your case (it takes current local commit and current local branch usually). Anyhow, I've added push permission to ovirt-3.* branches for vdsm-stable-maintainers, can you try again Yaniv? > > git push origin tagname > > works for me, but for Yaniv (i.e. it's a permission problem. Maybe the > permission model for tags in gerrit is not the one we suppose it is). > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra