Re: findbugs: 2 bll warnings, not related to patch?

Shahar/Einav - you are looking at the wrong patch. The "offending" patch with broke findbgus was merged yesterday: http://gerrit.ovirt.org/#/c/23103/ See also: http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs/6254/ Jiri/Doron - can you please fix this?

Thanks, Allon ----- Original Message ----- > From: "Shahar Havivi" <shaharh(a)redhat.com&gt; > To: "Einav Cohen" <ecohen(a)redhat.com&gt; > Cc: infra(a)ovirt.org, "Gilad Chaplik" <gchaplik(a)redhat.com&gt; > Sent: Wednesday, January 15, 2014 3:02:54 PM > Subject: Re: findbugs: 2 bll warnings, not related to patch? > > On 15.01.14 07:57, Einav Cohen wrote: >> Hi Gilad[/infra], >> >> I would like to merge patch [1], however I am getting 2 findbugs >> warnings on the BLL [2]. >> >> The patch is a frontend patch, so it has nothing to do with the >> BLL. >> >> findbugs is shouting on the 'equals' method of the PolicyUnit >> class [2]. it seems like the relevant code was merged quite >> a while ago [3] so I don't understand why it started shouting >> all of a sudden. >> >> any idea? > I get the same findbug errors as well > by looking at the log its looks like the last change is from August. > Maybe other change trigger it... > >> >> Many thanks in advance. >> >> ---- >> Regards, >> Einav >> >> [1] http://gerrit.ovirt.org/#/c/23027/ >> [2] >> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/4708/fi... >> [3] http://gerrit.ovirt.org/#/c/16107/ >> >> ----- Forwarded Message ----- >> From: "oVirt Jenkins CI Server" <gerrit2(a)gerrit.ovirt.org&gt; >> To: "Alexander Wels" <awels(a)redhat.com&gt;, "Einav Cohen" <ecohen(a)redhat.com&gt;, >> "Gilad Chaplik" <gchaplik(a)redhat.com&gt; >> Sent: Wednesday, January 15, 2014 7:38:37 AM >> Subject: Change in ovirt-engine[master]: webadmin: user session is kept >> alive >> >> oVirt Jenkins CI Server has posted comments on this change. >> >> Change subject: webadmin: user session is kept alive >> ...................................................................... >> >> >> Patch Set 3: Code-Review-1 >> >> Build Unstable >> >> http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit_old_us... >> : SUCCESS >> >> http://jenkins.ovirt.org/job/ovirt_engine_master_unit_tests_gerrit/5/ : >> SUCCESS >> >> http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerri... >> : SUCCESS >> >> http://jenkins.ovirt.org/job/ovirt_engine_master_find_bugs_gerrit/4708/ : >> UNSTABLE >> >> -- >> To view, visit http://gerrit.ovirt.org/23027 >> To unsubscribe, visit http://gerrit.ovirt.org/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: Ib99861bfdc41b98ceac0df7103acff5b9074f851 >> Gerrit-PatchSet: 3 >> Gerrit-Project: ovirt-engine >> Gerrit-Branch: master >> Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com&gt; >> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com&gt; >> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com&gt; >> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com&gt; >> Gerrit-Reviewer: oVirt Jenkins CI Server >> Gerrit-HasComments: No >> _______________________________________________ >> Infra mailing list >> Infra(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/infra > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra >