This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --srTfcOJvmarQ1Mrmmpc23c1qKLxg37X7h Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri 23 May 2014 11:47:52 AM CEST, Dan Kenigsberg wrote:
On Thu, May 22, 2014 at 05:45:45PM +0200, David Caro wrote:
On Thu 22 May 2014 03:50:23 PM CEST, Yaniv Dary wrote:
----- Original Message -----
From: "Vered Volansky" <vered@redhat.com> To: "infra" <infra@ovirt.org> Sent: Thursday, May 22, 2014 4:48:37 PM Subject: How come same version pep8 does't work the same?
I see a patch failing to build vsdm rpm on a pep8 error. pep8 versio=
n is
1.4.6, yet the actual pep8 job works jst fine. Same pep8 version to = both. How come?
Please upgrade your version of pep8. There were many changes in the latest update and this is probably cau= sing your issue.
Yaniv
I need to know why this happens in order to fix my job.
Patch in question: http://gerrit.ovirt.org/#/c/26759/5 pep8 job: http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9179/= console Failing job: http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_lo= calfs_gerrit/852/consoleFull
Thanks, Vered _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Couple of things to have in mind here:
The jobs that you sent are for different patches, I'll focus on the patch you sent only.
Why pep8 job did pass: - Because the pep8 job only checks the changes made in that patch, and in that patch, there were no issues (git diff HEAD~)
Why vdsm_master_storage_functional_tests_localfs_gerrit did not pass: - Because when compiling it will check all the files, not only the ones your patch changes, and your patch was based on an already failin= g patchset (http://gerrit.ovirt.org/#/c/27977/5/vdsm/BindingXMLRPC.py,cm= ).
You can see in the gerrit comments for that patchset that it did actually fail: Patch Set 5: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9162/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9305/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8374/ : SUCCESS
Mybe it's a good point to run pep8 on all the files and not only on th= e latest commit diff, to block any patchset based on a previously failin= g patch. Ideas?
I prefer to keep the diff. The previously-failing patch should be marke= d and fixed. If follow-ups are fine - let them be. Skipping pep8 (with PEP8=3Dtrue) during the storage job would have avoi= ded the issue in a cleaner way.
Ok, let me know what you decide you want and if there are any changes=20 needed on my side. -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --srTfcOJvmarQ1Mrmmpc23c1qKLxg37X7h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTfxpjAAoJEEBxx+HSYmnDX10H/RLy6D2R13HC1XxOaEYqVu4X x6KLiZ/Budc+wtey6TB7KEB1qJ5ql8howhZHj7R+PD1DM4WTBZ9VkEVv8rxgkSpc jTwjw52eHioZhPesmrHoPpRYYJ8TRm1RxsCj0srBfxKw83tP8+QEGPEZqdM24FMY 0S7/nIQp5nFZpN/3jFlsYDBoivzVV1BVpmJOhubPiPE6zX9LPAGkXxaFyPHxkGof usI+N2nH4f8js/fPZKBbjWtINfRP0dziMGIm8xVhsnu/fj6YWWYbCdMTmI0mKue2 loAyjgyKMQxDFtTK/9HyGzB4ySlW68ak5v5p5ZJWzfYmIl2RNQ8hkzLha2IUwLQ= =6mPe -----END PGP SIGNATURE----- --srTfcOJvmarQ1Mrmmpc23c1qKLxg37X7h--