From: "Eyal Edri" <eedri(a)redhat.com>
To: "Omer Frenkel" <ofrenkel(a)redhat.com>
Cc: "infra" <infra(a)ovirt.org>
Sent: Tuesday, June 16, 2015 3:35:15 PM
Subject: Re: findbugs fails with no reason
the findbugs yells on vdsdeploy file, and the patch did alter that file,
so if you believe that's false positive, you will need to update the xml
filter file
to ignore it.
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/39057/f...
VdsDeploy.java:720, DLS_DEAD_LOCAL_STORE, Priority: Low
Dead store to cer in
org.ovirt.engine.core.bll.hostdeploy.VdsDeploy.processEvent(Event$Base)
This instruction assigns a value to a local variable, but the value is not
read or used in any subsequent instruction. Often, this indicates an error,
because the value computed is never used.
Note that Sun's javac compiler often generates dead stores for final local
variables. Because FindBugs is a bytecode-based tool, there is no easy way
to eliminate these false positives.
this is what this patch is fixing
i think you are looking on the wrong result
jenkins fails at
----- Original Message -----
> From: "Omer Frenkel" <ofrenkel(a)redhat.com>
> To: "infra" <infra(a)ovirt.org>
> Sent: Tuesday, June 16, 2015 3:09:58 PM
> Subject: findbugs fails with no reason
>
> can someone please check
>
https://gerrit.ovirt.org/#/c/42422/
> Thanks
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
>
http://lists.ovirt.org/mailman/listinfo/infra
>
>
>
--
Eyal Edri
Supervisor, RHEV CI
EMEA ENG Virtualization R&D
Red Hat Israel
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)