Re: [ovirt-devel] [VDSM] build-artifacts failing on master
I'm not sure I understand your point. RPM spec files have %check section
for pre-build tests. Should we, or should we not, strive to use them?
AFAIK the %check section is only relevant for DS builds, as in US we
have many other places to run tests from (e.g check_patch.sh).
AFAIK by its nature %check only allows for source-level tests (since
you don't have an RPM yet). Source-level tests can and should run
before a patch is merged. The DS build, however, happens long after
the patch is merged, and by the time it does, all source-level issues
should have been checked for.
Therefore, I think making tests run in %check should not be a high priority.
--
Barak Korren
bkorren(a)redhat.com
RHEV-CI Team