----- Original Message -----
From: "Tal Nisan" <tnisan@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "Tomas Jelinek" <tjelinek@redhat.com> Cc: "Piotr Kliczewski" <pkliczew@redhat.com>, "infra" <infra@ovirt.org>, devel@ovirt.org Sent: Thursday, September 11, 2014 11:26:30 AM Subject: Re: [ovirt-devel] [URGENT][ACTION REQUIRED] oVirt engine on branch 3.5 doesn't build anymore
This was the commit that introduced this change - http://gerrit.ovirt.org/#/c/32542/ As you see it passed compilation successfully so no one really had a chance to know something was about to break
yes, running all-lang per patch isn't possible, the job takes 6 hours, i guess the only way to know is if we'd known this patch might affect the build with all lang, to verify before cherry-picking to 3.5 while running with all-langs... e.
On 09/11/2014 10:02 AM, Sandro Bonazzola wrote:
Il 11/09/2014 08:47, Tomas Jelinek ha scritto:
Hi,
the problem seems to be that the ApplicationMessages.vlanNetwork used to be: "{0} (VLAN {1})" while it has been changed to "(VLAN {0})"
But this change has not been reflected in the translated property files, e.g. ApplicationMessages_de_DE.properties ApplicationMessages_es_ES.properties ApplicationMessages_fr_FR.properties ApplicationMessages_ja_JP.properties ApplicationMessages_ko_KR.properties ApplicationMessages_pt_BR.properties ApplicationMessages_zh_CN.properties
which causes the compilation to fail if you enable the language permutations. How is it possible that this change landed on 3.5 branch? It should have failed (and it's failing) on master too so the patch should have been marked as -1 on verification and rejected. Or am I missing something?
I'm having a fix in a while, but I'm not entirely sure if it is correct to manually edit this files (they should be taken from zanata). If I'm not mistaken the process is that the files are generated from zanata and than manually commited to the sources. If that is the case, then this quick fix should do the trick until the new messages are available.
@Einav: Am I correct? Can I manually fix the property files?
thanx, Tomas
----- Original Message -----
From: "Sandro Bonazzola" <sbonazzo@redhat.com> To: devel@ovirt.org, "infra" <infra@ovirt.org> Sent: Thursday, September 11, 2014 8:14:02 AM Subject: [ovirt-devel] [URGENT][ACTION REQUIRED] oVirt engine on branch 3.5 doesn't build anymore
Hi, we should release oVirt 3.5.0 RC2 today but looks like it doesn't build anymore. Can you please fix it as soon as possible?
See: http://jenkins.ovirt.org/job/ovirt-engine_3.5_create-rpms_merged/221/ Thanks,
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel