Re: Sample UI plugins repository on gerrit.ovirt.org

On 11/17/2012 07:24 PM, Dan Kenigsberg wrote: >On Tue, Nov 13, 2012 at 08:46:45AM +0200, Itamar Heim wrote: >>On 11/12/2012 12:11 PM, Shahar Havivi wrote: >>>>From: Doron Fediuck <dfediuck(a)redhat.com&gt; >>>>To: Itamar Heim <iheim(a)redhat.com&gt; >>>>Cc: Juan Antonio Hernandez Fernandez <jhernand(a)redhat.com&gt;, Vojtech Szocs <vszocs(a)redhat.com&gt;, Einav Cohen <ecohen(a)redhat.com&gt;, infra(a)ovirt.org >>>>Sent: Wed, 07 Nov 2012 10:14:24 -0500 (EST) >>>>Subject: Re: Sample UI plugins repository on gerrit.ovirt.org >>>> >>>>----- Original Message ----- >>>>>From: "Itamar Heim" <iheim(a)redhat.com&gt; >>>>>To: "Michal Skrivanek" <michal.skrivanek(a)redhat.com&gt; >>>>>Cc: "Juan Antonio Hernandez Fernandez" <jhernand(a)redhat.com&gt;, "Vojtech Szocs" <vszocs(a)redhat.com&gt;, "Einav Cohen" &gt;&gt;&gt;&gt;&gt;&lt;ecohen(a)redhat.com&gt;, infra(a)ovirt.org >>>>>Sent: Wednesday, November 7, 2012 11:07:21 AM >>>>>Subject: Re: Sample UI plugins repository on gerrit.ovirt.org >>>>> >>>>>On 11/07/2012 09:54 AM, Michal Skrivanek wrote: >>>>>> >>>>>>On Nov 7, 2012, at 09:45 , Itamar Heim wrote: >>>>>> >>>>>>>On 11/02/2012 07:04 PM, Vojtech Szocs wrote: >>>>>>>>Hi guys, >>>>>>>> >>>>>>>>UI plugins is an upcoming oVirt feature that allows extending >>>>>>>>oVirt Engine functionality through Web Admin application's user >>>>>>>>interface. >>>>>>>> >>>>>>>>In addition to providing relevant documentation (wiki), I'd like >>>>>>>>to establish a git repository for hosting sample UI plugins. >>>>>>>>This will make it easier for others to get started with writing >>>>>>>>custom plugins, as well as document plugin API on examples. >>>>>>>> >>>>>>>>What do you think about creating such repository on >>>>>>>>gerrit.ovirt.org? (to be mirrored on github.com/oVirt) >>>>>>>> >>>>>>> >>>>>>>didn't see any replies on this. >>>>>>>+1 from me to host sample repos on ovirt gerrit. >>>>>>> >>>>>>>so if no nacks/comments, i'll add a samples-uiplugins repo to >>>>>>>gerrit next week. >>>>>>Is something similar planned for vdsm hooks as well? >>>>> >>>>>its an option, though it is managed today inside vdsm repo. >>>>>we also have some samples of very basic user portal in java/python >>>>>using >>>>>the REST API i'd like to place in a samples-portals repo. >>>Now that the ovirt engine support user level API, having a repository with >>>Samples of user-portal like implementations can be also useful. >>> >>>Can you add this repository as well? >>>> >>>>So why not have a samples repo for everything? >> >> >>i didn't hear any objections for both. >>created repo's: >>samples-uiplugins >>samples-portals >> >>danken, there is an open question if vdsm hooks should move to such >>a repo. i'm fine with "don't fix if it ain't broken", just know you >>have the option. > >As you have probably guessed, I prefer keeping vdsm's hooks where they >are - in vdsm's git tree. Hooks are (loosely) related to a vdsm version, >btw. Come to think of this, Laszlo, I think we should drop the cpupin >hook now that we have it as a fully-fledged vdsm feature. > well, someone may want it with an earlier version of engine - maybe rename them to .old? btw, its true for directlun, fileinject, promisc and smartcard (3.2).