Re: your patch https://gerrit.ovirt.org/#/c/40346/ broke oVirt vdsm jobs
----- Original Message -----
From: "Dan Kenigsberg" <danken(a)redhat.com>
To: "Barak Korren" <bkorren(a)redhat.com>
Cc: "Ido Barkan" <ibarkan(a)redhat.com>, "Francesco Romani"
<fromani(a)redhat.com>, "Infra" <infra(a)ovirt.org>,
"rhev-ci"
<rhev-ci(a)redhat.com>
Sent: Thursday, April 30, 2015 12:57:14 AM
Subject: Re: your patch https://gerrit.ovirt.org/#/c/40346/ broke oVirt vdsm jobs
On Wed, Apr 29, 2015 at 11:16:37AM -0400, Barak Korren wrote:
> Patch does not pass pyflakes:
>
> ./tests/samplingTests.py:30: 'libvirtconnection' imported but unused
> ./tests/samplingTests.py:36: 'MonkeyPatch' imported but unused
> make: *** [pyflakes] Error 1
>
> You could clearly see that the tests did not pass for patchset #6
> Please do not merge patches with failing tests!
Barak, thanks for reporting this mistake of ours.
https://gerrit.ovirt.org/#/c/40408/ would fix it momentarily.
I believe that it stems from two reasons:
- Ido did not run `make check` or `make pyflakes` before ticking
"verified" on the patch
- I failed to wait for the jenkins job to finish.
We will configure Jenkins to set -1 to make such mistakes harder to make.
To make sure that this does not repeat I should avoid merging
freshly-posted patches. Ido should take better care for pep8 and
pyflakes. I have vim plugins that help me avoid such mistakes
I hear that http://www.vim.org/scripts/script.php?script_id=4440 is
better than what I actually have.
I recommend https://github.com/scrooloose/syntastic its the one ring to rule them all...
Regards,
Dan.