Re: Gerrit hooks doesn't mark open patches in other branches as -verified

The hook found out that the patch is open in master which precedes ovirt-engine-4.1 and thus should have gotten -verified in 4.1 On Wed, Dec 21, 2016 at 12:55 PM, Shlomo Ben David <sbendavi(a)redhat.com&gt; wrote: > Hi Tal, > > I think that the Check Backport hook is doing exactly what you asking for. > Example [1]: > > - Check Backport::IGNORE, The patch backported to all newer > branches.(open in 'master' branch/es) found not relevant branch/es: > 'ovirt-engine-4.0' (not exist in the newer branches list) > > patch branch: ovirt-engine-4.1 > newer branches: 'master' (open) > older (not relevant) branches: ovirt-engine-4.0 > > If it's not what you meant, please explain :) > > [1] - https://gerrit.ovirt.org/#/c/68862 > > > Best Regards, > > Shlomi Ben-David | Software Engineer | Red Hat ISRAEL > RHCSA | RHCE > IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) > > OPEN SOURCE - 1 4 011 && 011 4 1 > > On Wed, Dec 21, 2016 at 12:39 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: > >> Check out this patches for instance: https://gerrit.ovirt.org/#/c/68862 >> https://gerrit.ovirt.org/#/c/68861 >> Those are 4.1 and 4.0 patches that are open on master, I'd expect to see >> them get -verified from the hooks which they didn't: >> >> - Update Tracker::#1406042::OK, status: POST >> - Check Bug-Url::OK >> - Check Product::#1406042::OK, product: ovirt-engine >> - Check TM::#1406042::OK, found clone candidate ovirt-4.0.zfor >> target milestone: ovirt-4.0.7 >> - Set POST::#1406042::IGNORE, bug is already in 'POST' status >> - Check Backport::IGNORE, The patch backported to all newer >> branches.(open in 'master' branch/es) found not relevant branch/es: >> 'ovirt-engine-4.0' (not exist in the newer branches list) >> >> This was the flow before and it made my life easier as I didn't have to >> actively search for cherry-picks in all other branches to see if it can be >> merged >> >> _______________________________________________ >> Infra mailing list >> Infra(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/infra >> >> >