--Apple-Mail=_ABF30BAE-59CC-4D45-9FBD-AA99278442C4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8
On 12 Jul 2016, at 09:19, Yaniv Kaul <ykaul@redhat.com> wrote: =20 =20 =20 On Tue, Jul 12, 2016 at 10:12 AM, Francesco Romani <fromani@redhat.com = <mailto:fromani@redhat.com>> wrote: =20 =20 ----- Original Message -----
From: "Dan Kenigsberg" <danken@redhat.com = <mailto:danken@redhat.com>> To: "Nadav Goldin" <ngoldin@redhat.com <mailto:ngoldin@redhat.com>>, = fromani@redhat.com <mailto:fromani@redhat.com> Cc: "Eyal Edri" <eedri@redhat.com <mailto:eedri@redhat.com>>, "Nir = Soffer" <nsoffer@redhat.com <mailto:nsoffer@redhat.com>>, "Yaniv Kaul" = <ykaul@redhat.com <mailto:ykaul@redhat.com>>, "Martin Perina" <mperina@redhat.com <mailto:mperina@redhat.com>>, "Tolik = Litovsky" <tlitovsk@redhat.com <mailto:tlitovsk@redhat.com>>, "infra" = <infra@ovirt.org <mailto:infra@ovirt.org>> Sent: Monday, July 11, 2016 10:12:48 PM Subject: Re: Build failed in Jenkins: ovirt_master_system-tests #243
On Thu, Jul 07, 2016 at 07:00:35PM +0300, Nadav Goldin wrote:
Seems like [1], as ovirt-srv19 has fresh new FC24 installation, virtlogd is not enabled by default: =E2=97=8F virtlogd.service - Virtual machine log manager Loaded: loaded (/usr/lib/systemd/system/virtlogd.service; = indirect; vendor preset: disabled) Active: inactive (dead) Docs: man:virtlogd(8) http://libvirt.org <http://libvirt.org/> we can add it to puppet for now.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=3D1290357 = <https://bugzilla.redhat.com/show_bug.cgi?id=3D1290357>
Francesco, shouldn't vdsm require virtlogd explicitly? =20 Disclaimer: I didn't read yet the rest of the thread. =20 We choose not to, trying to prevent issues: https://gerrit.ovirt.org/#/c/55189/1 = <https://gerrit.ovirt.org/#/c/55189/1> Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=3D1318902 = <https://bugzilla.redhat.com/show_bug.cgi?id=3D1318902> =20 I thought and still do it's quite a mistake - if we think a feature of = our friends from libvirt is immature - we should tell them that, = hopefully accompanied by bugs.
I'd like to believe they don't enable features by default unless they = believe the features are mature and ready for general consumption. If =
It=E2=80=99s not so much feature itself, rather it=E2=80=99s integration = into OSes. I think there was enough feedback, a random google search = shows a load of issues reported at the time this dependency was = introduced, so I hope they learned from it that's not the case, we should talk with them. IMO it was a bit hasty on their part, and we just didn=E2=80=99t have = time to resolve all the virtlogd daemon management in RHEL and RHEVH in = time Thanks, michal
Y. =20 =20 We want to reenable and require it in the near future: https://bugzilla.redhat.com/show_bug.cgi?id=3D1321010 = <https://bugzilla.redhat.com/show_bug.cgi?id=3D1321010> =20 HTH, =20 -- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani =20
--Apple-Mail=_ABF30BAE-59CC-4D45-9FBD-AA99278442C4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" = class=3D""><br class=3D""><div><blockquote type=3D"cite" class=3D""><div = class=3D"">On 12 Jul 2016, at 09:19, Yaniv Kaul <<a = href=3D"mailto:ykaul@redhat.com" class=3D"">ykaul@redhat.com</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = dir=3D"ltr" class=3D""><br class=3D""><div class=3D"gmail_extra"><br = class=3D""><div class=3D"gmail_quote">On Tue, Jul 12, 2016 at 10:12 AM, = Francesco Romani <span dir=3D"ltr" class=3D""><<a = href=3D"mailto:fromani@redhat.com" target=3D"_blank" = class=3D"">fromani@redhat.com</a>></span> wrote:<br = class=3D""><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 = .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=3D""><br = class=3D""> <br class=3D""> ----- Original Message -----<br class=3D""> > From: "Dan Kenigsberg" <<a href=3D"mailto:danken@redhat.com" = class=3D"">danken@redhat.com</a>><br class=3D""> > To: "Nadav Goldin" <<a href=3D"mailto:ngoldin@redhat.com" = class=3D"">ngoldin@redhat.com</a>>, <a = href=3D"mailto:fromani@redhat.com" class=3D"">fromani@redhat.com</a><br = class=3D""> > Cc: "Eyal Edri" <<a href=3D"mailto:eedri@redhat.com" = class=3D"">eedri@redhat.com</a>>, "Nir Soffer" <<a = href=3D"mailto:nsoffer@redhat.com" class=3D"">nsoffer@redhat.com</a>>, = "Yaniv Kaul" <<a href=3D"mailto:ykaul@redhat.com" = class=3D"">ykaul@redhat.com</a>>, "Martin<br class=3D""> > Perina" <<a href=3D"mailto:mperina@redhat.com" = class=3D"">mperina@redhat.com</a>>, "Tolik Litovsky" <<a = href=3D"mailto:tlitovsk@redhat.com" = class=3D"">tlitovsk@redhat.com</a>>, "infra" <<a = href=3D"mailto:infra@ovirt.org" class=3D"">infra@ovirt.org</a>><br = class=3D""> > Sent: Monday, July 11, 2016 10:12:48 PM<br class=3D""> > Subject: Re: Build failed in Jenkins: ovirt_master_system-tests = #243<br class=3D""> ><br class=3D""> </span><span class=3D"">> On Thu, Jul 07, 2016 at 07:00:35PM +0300, = Nadav Goldin wrote:<br class=3D""> > > Seems like [1], as ovirt-srv19 has fresh new FC24 = installation,<br class=3D""> > > virtlogd is not enabled by default:<br class=3D""> > > =E2=97=8F virtlogd.service - Virtual machine log manager<br = class=3D""> > > Loaded: loaded = (/usr/lib/systemd/system/virtlogd.service; indirect;<br class=3D""> > > vendor preset: disabled)<br class=3D""> > > Active: inactive (dead)<br class=3D""> > > Docs: man:virtlogd(8)<br class=3D""> > > <a = href=3D"http://libvirt.org/" rel=3D"noreferrer" target=3D"_blank" = class=3D"">http://libvirt.org</a><br class=3D""> > > we can add it to puppet for now.<br class=3D""> > ><br class=3D""> > > [1] <a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1290357" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">https://bugzilla.redhat.com/show_bug.cgi?id=3D1290357</a><br = class=3D""> ><br class=3D""> > Francesco, shouldn't vdsm require virtlogd explicitly?<br class=3D"">= <br class=3D""> </span>Disclaimer: I didn't read yet the rest of the thread.<br = class=3D""> <br class=3D""> We choose not to, trying to prevent issues:<br class=3D""> <a href=3D"https://gerrit.ovirt.org/#/c/55189/1" rel=3D"noreferrer" = target=3D"_blank" class=3D"">https://gerrit.ovirt.org/#/c/55189/1</a><br = class=3D""> Related-To: <a = href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1318902" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">https://bugzilla.redhat.com/show_bug.cgi?id=3D1318902</a></bloc= kquote><div class=3D""><br class=3D""></div><div class=3D"">I thought = and still do it's quite a mistake - if we think a feature of our friends = from libvirt is immature - we should tell them that, hopefully = accompanied by bugs.</div></div></div></div></div></blockquote><div><br = class=3D""></div>It=E2=80=99s not so much feature itself, rather it=E2=80=99= s integration into OSes. I think there was enough feedback, a random = google search shows a load of issues reported at the time this = dependency was introduced, so I hope they learned from it</div><div><br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = dir=3D"ltr" class=3D""><div class=3D"gmail_extra"><div = class=3D"gmail_quote"><div class=3D"">I'd like to believe they don't = enable features by default unless they believe the features are mature = and ready for general consumption. If that's not the case, we should = talk with them.</div></div></div></div></div></blockquote><div><br = class=3D""></div>IMO it was a bit hasty on their part, and we just = didn=E2=80=99t have time to resolve all the virtlogd daemon management = in RHEL and RHEVH in time</div><div><br = class=3D""></div><div>Thanks,</div><div>michal</div><div><br = class=3D""></div><div><br class=3D""><blockquote type=3D"cite" = class=3D""><div class=3D""><div dir=3D"ltr" class=3D""><div = class=3D"gmail_extra"><div class=3D"gmail_quote"><div = class=3D"">Y.</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 = 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class=3D""> <br class=3D""> We want to reenable and require it in the near future:<br class=3D""> <a href=3D"https://bugzilla.redhat.com/show_bug.cgi?id=3D1321010" = rel=3D"noreferrer" target=3D"_blank" = class=3D"">https://bugzilla.redhat.com/show_bug.cgi?id=3D1321010</a><br = class=3D""> <br class=3D""> HTH,<br class=3D""> <span class=3D"HOEnZb"><font color=3D"#888888" class=3D""><br class=3D""> --<br class=3D""> Francesco Romani<br class=3D""> RedHat Engineering Virtualization R & D<br class=3D""> Phone: 8261328<br class=3D""> IRC: fromani<br class=3D""> </font></span></blockquote></div><br class=3D""></div></div> </div></blockquote></div><br class=3D""></body></html>= --Apple-Mail=_ABF30BAE-59CC-4D45-9FBD-AA99278442C4--