Re: Fwd: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely

On Tue, Feb 2, 2016 at 12:28 PM, David Caro <dcaro(a)redhat.com&gt; wrote: > On 02/02 11:45, Yedidyah Bar David wrote: >> (Sorry, this time to the right address) >> >> >> ---------- Forwarded message ---------- >> From: Yedidyah Bar David <didi(a)redhat.com&gt; >> Date: Sun, Jan 31, 2016 at 1:20 PM >> Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: >> rename: Handle storage domains more nicely >> To: Jenkins CI <gerrit2(a)gerrit.ovirt.org&gt; >> >> >> On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2(a)gerrit.ovirt.org= wrote: >> > Jenkins CI has posted comments on this change. >> > >> > Change subject: packaging: rename: Handle storage domains more nicely >> > ....................................................................=

>> > >> > >> > Patch Set 1: Continuous-Integration-1 >> > >> > Build Failed >> > >> > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64=

>> > >> > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64=

>> >> Both of these are pep8: >> >> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:3=

>> E126 continuation line over-indented for hanging indent >> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:3=

>> E126 continuation line over-indented for hanging indent >> >> > >> > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_6=

>> >> How come this one passed? >> >> Do we have different versions/configuration of pep8 in different >> OSes? > > Unless you are explicitly specifying a version of pep8 yes, they > probably have different versions for different oses. =20 Indeed, and el6 and el7 had old, buggy versions. =20 > >> >> Also note that E126 is ignored by default, see e.g.: >> >> https://github.com/PyCQA/pep8/issues/265 >> https://github.com/PyCQA/pep8/pull/360 >> > > It's up to the project owners to decide what to test and how, for what > I can see the script that runs pep8/pyflakes on the code is under, > build/python-check.sh.in, and it was written by abarlev, so maybe you > should talk to whomever inherited he's responsabilities (I don't know > who that is, sorry, try on devel list) =20 For el7 we already had a newer one on [1]. =20 For el6 I built the srpm. =20 Sandro now copied both to ci-tools [2] [3]. FYI and thanks.

=20 [1] http://mirror.centos.org/centos/7/virt/x86_64/ovirt-3.6/common/ [2] http://resources.ovirt.org/repos/ci-tools/el6/noarch/ [3] http://resources.ovirt.org/repos/ci-tools/el7/noarch/ =20 --=20 Didi _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWsL1uAAoJEEBxx+HSYmnDlCUIAJAZlKo7U4fzlIn85B8ahjQh D7tjxEMHT9IDu3xXgba77/FwaEV2c1NQxBSWXbHSE50OWkeBe8U8H4LJssXYr/6s h5p1iUzyNcdX21VoGNAyeeR8pxjodNJXZ9mK0I7YKmWkZaABxEGjcyGFKFvdmnGq lXUTL/cdTgxEbv/adskq45LKuDtq9h9edjybd3nkgwEk6/UrbX85X15vZR4nemNx KM5uQmZRpF4TlNcjLHgETGB3SSoB76Za6u0tqVvNcvHVSaqUtWyUcdnMxFRjZbH2 IMQLtfGcHRQoRYULdsra+aPK2sOgV15wqgDVEFAj3XaBem+LEtiM3VeetmhnMVQ= =1Spu -----END PGP SIGNATURE-----