--cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 06/16, Eyal Edri wrote:
Sounds like a bug. Jenkins should only use the CI flag and not change CR and V flags. =20 Might have been a misunderstanding. David, can you fix it so Jenkins will only update CI flag?
Can someone pass me an example of the patch that had the reviews? It's poss= ible that previously the jobs were manually modified to only set the ci flag and= we updated them on yaml and the manual changes got reverted. Having a sample p= atch would allow me to trim down the list of possible jobs that give that review. That can be prevented globally easily, but until all projects have the ci f= lag we can't enforce it globally.
=20 E. =20 Eyal Edri Supervisor, RHEV CI Red Hat =20 From: Dan Kenigsberg Sent: Jun 16, 2015 7:06 PM To: infra@ovirt.org Cc: eedri@redhat.com; dcaro@redhat.com Subject: Jenkins CI granting excessive +1s =20
As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for=20 every patchset that it successfully passed.=20
Was this change somehow intentional?=20
It is confusing and unwanted. Only a human developer can give a=20 meaningful Code-Review. Only a human user/QE can say that a patch solve= d=20 the relevant bug and grant it Verfied+1. The flags that Jenkins grant= =20 are meaningless.=20
Can this be stopped? Jenkins should give CI+1 if it's happe with a=20 patch, or CI-1 if it is has not yet run (or failed).=20
Regards,=20 Dan.=20
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVgG9xAAoJEEBxx+HSYmnDFssH/1YwVv4UTBevYxE+u1jbqPNV Ui0SgiY/HZ2LuvHDPZ7hTyZ51HdYnyYJ9eT6mh7h6/WtwTHYUBrIfFexm83t4abf vNY43qUrx7mh+TVuIjOSNYVJKPOWlRvCO4jvB4VOCrI+j/X1ab/67/TE04Cw1/xi huoAwjNq9dKqa4JzPfdqU6RIiqZA3gu6tl5+VEjwM+SdmkYAAVapNb+iemt6l9Nv M/JqVeskSK4KaReOdFzJNxnmAfGT0Ioa8SwBnnIyCTQg5NN9Q40bLiRlDeNsndDL KSWv6CnXBUaqPxz2xlHSdAtklc6AcrKXUTeJUpr3F9MjT8cRLVm+s9tlYQ4pAbo= =3E8Z -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e--