Re: Invalid version of pep8 on some slaves

From: "David Caro" <dcaroest(a)redhat.com&gt; To: "Nir Soffer" <nsoffer(a)redhat.com&gt; Cc: "infra" <infra(a)ovirt.org&gt; Sent: Thursday, August 21, 2014 8:15:12 PM Subject: Re: Invalid version of pep8 on some slaves On 08/21, Nir Soffer wrote: > Hi infra, > > There is too old version of pep8 used on some slave, that cause pep8 test > to fail for > valid sources. > > Here is one example: > > http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11846/console > > gerrit failure: > > + pep8 --version > 1.4.5 > + git diff HEAD~ > + sed 's%^./*%%' > + pep8 --diff '--filename=*.py,*.py.in,*/vdsm,*/supervdsmServer' > + [[ 1 -ne 0 ]] > + echo 'PEP8 Failed' > PEP8 Failed > + cat /home/jenkins/workspace/vdsm_master_pep8_gerrit/violations.xml > lib/vdsm/tool/configurator.py:41:9: E123 closing bracket does not match > indentation of opening bracket's line > > Running pep8 on Fedora 19 (version 1.4.6): That's a centos 6 slave, and it seens that's the greatest python-pep8 we have for centos, it's greater than the on here: http://www.ovirt.org/Vdsm_Developers

Can you please supply the correct version so we can add it to our repos? Thanks! > > $ pep8 lib/vdsm/tool/configurator.py; echo $? > 0 > > Thanks, > Nir > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro(a)redhat.com Web: www.redhat.com RHT Global #: 82-62605