Re: How come same version pep8 does't work the same?

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aAjJfRiPafruJw9FObAKgWsInrmOJsBI9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu 22 May 2014 03:50:23 PM CEST, Yaniv Dary wrote: is th. ng your issue. nsole lfs_gerrit/852/consoleFull Couple of things to have in mind here: The jobs that you sent are for different patches, I'll focus on the=20 patch you sent only. Why pep8 job did pass: - Because the pep8 job only checks the changes made in that patch,=20 and in that patch, there were no issues (git diff HEAD~) Why vdsm_master_storage_functional_tests_localfs_gerrit did not pass: - Because when compiling it will check all the files, not only the=20 ones your patch changes, and your patch was based on an already failing=20 patchset (http://gerrit.ovirt.org/#/c/27977/5/vdsm/BindingXMLRPC.py,cm). You can see in the gerrit comments for that patchset that it did=20 actually fail: Patch Set 5: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9162/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9305/ :=20 SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8374/ :=20 SUCCESS Mybe it's a good point to run pep8 on all the files and not only on the=20 latest commit diff, to block any patchset based on a previously failing=20 patch. Ideas? -- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro(a)redhat.com Web: www.redhat.com RHT Global #: 82-62605 --aAjJfRiPafruJw9FObAKgWsInrmOJsBI9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" --aAjJfRiPafruJw9FObAKgWsInrmOJsBI9--