[
https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jir...
]
Barak Korren commented on OVIRT-1154:
-------------------------------------
We don't want to significantly slow down the CI because of this, a good guideline
should be for the whole whitelist matching process to take:
# At most 1 network fetch (right not if fetches once via cloning from Gerrit)
# At most O\(n) time to search the match, where 'n' is the *number of
contributors* as opposed to *number of patches*
AFAIK we don't keep lists of contributors anywhere ATM, so we'll probably need to
scan patches to see who contributed. We may not be able to practically do this fast
enough. We will need to check if Git or Gerrit can do this efficiently for us ahead of
time.
We also need some proper definition of who is considered a contributor. I don't think
that someone with a merged patch ever is a good heuristic, should probably be something
like N patches merged in the last M months.
Make jenkins-whitelist use Gerrit groups
----------------------------------------
Key: OVIRT-1154
URL:
https://ovirt-jira.atlassian.net/browse/OVIRT-1154
Project: oVirt - virtualization made easy
Issue Type: Improvement
Components: Jenkins
Reporter: Barak Korren
Assignee: infra
Right now our white list is based on a text file with email addresses in it. Its kinda
silly when we already have lists and groups of users in Gerrit.
Some suggestions:
* make any members of a project's "maintainers" group automatically
white-listed
* make a specific group for other white-listed people
--
This message was sent by Atlassian JIRA
(v1000.769.1#100032)