Re: DAO test and upgrade appear not to run on 4.0 branch

On Wed, May 25, 2016 at 3:33 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: > > > On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > >> db upgrade jobs should be covered by engine-setup/upgrade so I don't see >> a reason to keep running them. >> > You mean the checkpatch jobs cover them? Cause upgrade scripts changes > need to be tested as well > 2 things IMO cover this: 1. the db duplicate script in check-patch.sh 2. ovirt-engine setup/upgrade not in standard ci (since we can't run setup on mock) If this is not the case, we need to migrate the db scripts to check-patch.

> >> On Wed, May 25, 2016 at 3:29 PM, Eyal Edri <eedri(a)redhat.com&gt; wrote: >> >>> Dao tests are run in the old jenkins still (pending migrate to standard >>> ci - we'll appreciate help from DEV migrating it). >>> Right now i'm cloning the jobs to run on 4.0 on old-jenkins. >>> >> What's needed for that migration? > Just to copy the code to a bash script and test it, i started a very draft and ugly code here: https://gerrit.ovirt.org/#/c/55808/

> >>> >>> >>> On Wed, May 25, 2016 at 3:11 PM, Tal Nisan <tnisan(a)redhat.com&gt; wrote: >>> >>>> Encountered that in this patch: >>>> https://gerrit.ovirt.org/#/c/58034/ >>>> >>>> It introduces both an upgrade script change and a change in the DAO >>>> layer yet it seems that DAO tests and upgrade test did not run >>>> >>>> >>>> _______________________________________________ >>>> Infra mailing list >>>> Infra(a)ovirt.org >>>> http://lists.ovirt.org/mailman/listinfo/infra >>>> >>>> >>> >>> >>> -- >>> Eyal Edri >>> Associate Manager >>> RHEV DevOps >>> EMEA ENG Virtualization R&D >>> Red Hat Israel >>> >>> phone: +972-9-7692018 >>> irc: eedri (on #tlv #rhev-dev #rhev-integ) >>> >> >> >> >> -- >> Eyal Edri >> Associate Manager >> RHEV DevOps >> EMEA ENG Virtualization R&D >> Red Hat Israel >> >> phone: +972-9-7692018 >> irc: eedri (on #tlv #rhev-dev #rhev-integ) >> > > -- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)