Re: Dropping rpm build from ovirt-engine check-merged.sh

On Mon, Sep 19, 2016 at 9:41 AM, Sandro Bonazzola <sbonazzo(a)redhat.com&gt; wrote: > > > On Sun, Sep 18, 2016 at 4:18 PM, Eyal Edri <eedri(a)redhat.com&gt; wrote: > >> Hi, >> >> Following [1] I'd like to propose to remove rpm building from the >> 'check-merged.sh' script from ovirt-engine (master for now). >> >> The job [2] takes on avg 15 min while actually the rpms are built >> already in check-patch >> (with gwt draft mode if needed) and runs exactly the same build rpm >> command as check-patch [3]. >> >> So there isn't real value in running exactly the same rpm build post >> merge, and we already build full permutation mode in 'build-artifacts.sh'. >> >> Any reason to keep it? >> We can cut down valuable time in CI if we drop it and vacant more time >> for more meaningful tests. >> > > > This depends on the flow: if we make check_merge gating to the merge and > to the build we should keep the rpm build becuase at merge a rebase is done > automatically. > What do you mean by 'gating to the merge'? I'm not sure I understand what it means. Isn't check-patch.sh does the gating? check-merge runs post merge so its already too late to gate the code ... And I think check-merge and check-patch currently runs the same rpmbuild command, so I don't see how check-merged has any value over check-patch.

> If there's not gating process performed by check-merge then I agree in > dropping rpm build. > > > >> >> >> [1] https://ovirt-jira.atlassian.net/browse/OVIRT-416 >> [2] http://jenkins.ovirt.org/job/ovirt-engine_master_check-m >> erged-el7-x86_64/buildTimeTrend >> [3] >> rpmbuild \ >> -D "_rpmdir $PWD/output" \ >> -D "_topmdir $PWD/rpmbuild" \ >> -D "release_suffix ${SUFFIX}" \ >> -D "ovirt_build_ut $BUILD_UT" \ >> -D "ovirt_build_extra_flags $EXTRA_BUILD_FLAGS" \ >> -D "ovirt_build_draft 1" \ >> --rebuild output/*.src.rpm >> >> >> -- >> Eyal Edri >> Associate Manager >> RHV DevOps >> EMEA ENG Virtualization R&D >> Red Hat Israel >> >> phone: +972-9-7692018 >> irc: eedri (on #tlv #rhev-dev #rhev-integ) >> > > > > -- > Sandro Bonazzola > Better technology. Faster innovation. Powered by community collaboration. > See how it works at redhat.com > <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016> > -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)