This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sfrrv3Sx8L9iA1gjr7D1aHoINgo23j0Ad Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed 21 May 2014 04:25:41 PM CEST, Eyal Edri wrote:
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Sandro Bonazzola" <sbonazzo@redhat.com>, "David Caro" <dcaroest@r=
edhat.com>
Cc: "infra" <infra@ovirt.org> Sent: Friday, May 16, 2014 9:48:19 PM Subject: Re: About merging patches without tests
On 05/16/2014 05:38 AM, Sandro Bonazzola wrote:
Il 16/05/2014 10:37, David Caro ha scritto:
On Fri 16 May 2014 09:33:44 AM CEST, Sandro Bonazzola wrote:
Il 15/05/2014 18:46, David Caro ha scritto:
Hi!
From time to time we have some patches that are merged to master branches without having been tested mostly because the developer merges bef= ore having any response from the jenkins system.
Merging one of those patches makes any following test run on that = branch to fail, and creating a lot of noise and trouble around all patches a= nd jobs.
So I wanted to stat a little discussion to bring up ideas on how t= o prevent that. Some random thoughts:
* -1 the patch at jenkins job start, and reset to 0 on success or = infra failure, and keep -1 if jenkins failure * Only send a message to the patch with 'jenkins jobs started'
I think that something like "jenkins jobs started, please don't mer= ge until they finish" should be enough.
* Setup zuul as gateway, and make it block the patches if they do = not pass the tests
Cheers!
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Usually the flow is reabase -> submit, that is done pretty easily fr= om the ui, and it does not give too much time to check any comments (th= e rebase and submit buttons are on the top, and the comments show at t= he end). So doing that will not help on that case, as the developer would not=
see the comment before submitting. I think we should block, at least=
for a couple minutes, so he has to read the comments to be able to submit.
We had that before also, adding a comment when the jobs start, but w= e removed it by developers request iirc
Also recently you can just press submit and it automatically rebase b= efore merging. So maybe yes, just a message isn't enough
its not possible to wait for the job on a simple rebase usually - too many collisions possible.
we're mostly talking about jobs that fail to compile, i think in those = cases, it worth to wait for jenkins job to finish.
Maybe we can try to add a new flag 'jenkins ran' or similar (maybe=20 tested) that is set by jenkins (or a maintainer) and required to merge?
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --Sfrrv3Sx8L9iA1gjr7D1aHoINgo23j0Ad Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTfLfTAAoJEEBxx+HSYmnDxrUIAJV5c7sWEAVkkqDGov5xtsf4 u6NJdpda6zQcYUlmM9kWQfhGgMIbS3ogFUJEYjcvvnQSXjhSKBPuq7dYO0h6gxRa t+w4zrpOzZRuXUNEE60HqkbM13599Q5isiVkyfWqdzy9dxSZm3aAQ4V+Bah/RCTh nuR4QioHJj2xviBFHuOmTZIZhVJeJ+ImJwu4C1bklGtmpcyNMDTG303WBm1hfUaH 6AlbubypmZewjdQ59N8dDWtSCzwNtoQbSjd0S1BDdruV5+2UluV7U5sJu8fi++O9 Se9bbJurxLm41LTRh4ooZNJTSDWRSksLMI63Ab1R8oa5vD/ZiBRk9UQSZccZ4eU= =GSx6 -----END PGP SIGNATURE----- --Sfrrv3Sx8L9iA1gjr7D1aHoINgo23j0Ad--