------=_Part_21924418_1642346865.1403515141493 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit The attached patch fixes locally. ----- Original Message -----
From: "Francesco Romani" <fromani@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, June 23, 2014 10:48:23 AM Subject: F20 python 2.7.5-12 breaks cpopen
Hi Infra,
I just discovered the hard way that the last python package in F20
# rpm -qi python Name : python Version : 2.7.5 Release : 12.fc20 Architecture: x86_64 Install Date: Mon 23 Jun 2014 08:28:32 AM CEST Group : Development/Languages Size : 80819 License : Python Signature : RSA/SHA256, Thu 19 Jun 2014 04:49:28 PM CEST, Key ID 2eb161fa246110c1 Source RPM : python-2.7.5-12.fc20.src.rpm Build Date : Thu 19 Jun 2014 02:54:35 PM CEST Build Host : buildvm-24.phx2.fedoraproject.org Relocations : (not relocatable) Packager : Fedora Project Vendor : Fedora Project URL : http://www.python.org/ Summary : An interpreted, interactive, object-oriented programming language
[...]
Includes this apparently innocuous change: * Thu Jun 19 2014 Bohuslav Kabrda <bkabrda@redhat.com> - 2.7.5-12 - Fix test failures with SQLite 3.8.4 - Fix double close of subprocess pipes when child process fails Resolves: rhbz#1103450 <<< THIS ONE!
Which is http://hg.python.org/cpython/rev/43749cb6bdbd
If we try to run VDSM tests using cpopen 1.3-2[1]
we'll get: http://fpaste.org/112115/
the fix is simple: just use execute_child_v276 and everything will work again. How can we detect and react properly to this schenario, however?
Thanks,
+++
[1] # rpm -qi python-cpopen Name : python-cpopen Version : 1.3 Release : 2.fc20 Architecture: x86_64 Install Date: Sat 15 Feb 2014 09:50:01 PM CET
-- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Francesco Romani RedHat Engineering Virtualization R & D Phone: 8261328 IRC: fromani ------=_Part_21924418_1642346865.1403515141493 Content-Type: text/x-patch; name=0001-compatibility-with-F20-s-python-2.7.5-12.patch Content-Disposition: attachment; filename=0001-compatibility-with-F20-s-python-2.7.5-12.patch Content-Transfer-Encoding: base64 RnJvbSBhNTg5NTUwNWQwNTFkZmUzODdjNTczNDc0ZTcxYjNmYWY2OTZmY2YwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGcmFuY2VzY28gUm9tYW5pIDxmcm9tYW5pQHJlZGhhdC5jb20+ CkRhdGU6IE1vbiwgMjMgSnVuIDIwMTQgMTE6MTc6NDcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBj b21wYXRpYmlsaXR5IHdpdGggRjIwJ3MgcHl0aG9uIDIuNy41LTEyCgotLS0KIGNwb3Blbi9fX2lu aXRfXy5weSB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvY3BvcGVuL19faW5pdF9fLnB5IGIvY3BvcGVuL19faW5pdF9fLnB5CmluZGV4IDQ2ZWQ0 NDYuLmNlYTAwMWUgMTAwNjQ0Ci0tLSBhL2Nwb3Blbi9fX2luaXRfXy5weQorKysgYi9jcG9wZW4v X19pbml0X18ucHkKQEAgLTI2LDYgKzI2LDcgQEAgVGhpcyBpcyBhIHNpbXBsZXIgbWV0aG9kIG9m IGV4ZWNpbmcgdGhhdCBkb2Vzbid0IGdvIGJhY2sgdG8gcHl0aG9uIGFmdGVyCiBmb3JraW5nLiBU aGlzIGFsbG93cyBmb3IgZmFzdGVyIHNhZmVyIGV4ZWMuCiAiIiIKIAoraW1wb3J0IGluc3BlY3QK IGltcG9ydCBvcwogaW1wb3J0IHN5cwogZnJvbSBzdWJwcm9jZXNzIGltcG9ydCBQb3BlbiwgUElQ RQpAQCAtMTAxLDUgKzEwMiw3IEBAIGNsYXNzIENQb3BlbihQb3Blbik6CiAKICAgICBpZiBzeXMu dmVyc2lvbl9pbmZvWzA6M10gPj0gKDIsIDcsIDYpOgogICAgICAgICBfZXhlY3V0ZV9jaGlsZCA9 IF9leGVjdXRlX2NoaWxkX3YyNzYKKyAgICBlbGlmICd0b19jbG9zZScgaW4gaW5zcGVjdC5nZXRh cmdzcGVjKFBvcGVuLl9leGVjdXRlX2NoaWxkKS5hcmdzOgorICAgICAgICBfZXhlY3V0ZV9jaGls ZCA9IF9leGVjdXRlX2NoaWxkX3YyNzYKICAgICBlbHNlOgogICAgICAgICBfZXhlY3V0ZV9jaGls ZCA9IF9leGVjdXRlX2NoaWxkX3YyNzUKLS0gCjEuOS4zCgo= ------=_Part_21924418_1642346865.1403515141493--