--VrqPEDrXMn8OVzN4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline hi, Dan. makes sense to me to focus on 2 use cases: - pre-commit hook running everything jenkins is running - locally - pros: - nearly identical checks/tests jenkins would running - doesn't care about IDE/editor - cons: - slower - can be annoying to commit (locally) broken code for later squashing - editor/IDE marriage with tests/checks running - pros: - dev has full control over what runs in checks/tests - allows to commit "dirty" commit - shorter ==> quicker than the quickest jenkins option - cons: - depends on IDE/editor support - less checks/tests => higher risk I did both with: intelliJ/PyCharm and vim, almost 100% sure PyDev allows this. either allows ease of running tests - in 1st case upon git commit, in the latter - via a button/shortcut in the devtool. I can help with setting up either to an early adopter. Then give it a week or two to get some feedback later how well it goes. Besides, we're also trying to speedup jenkins response all the time WDYT? On Wed, Apr 29, 2015 at 10:57:14PM +0100, Dan Kenigsberg wrote:
On Wed, Apr 29, 2015 at 11:16:37AM -0400, Barak Korren wrote:
Patch does not pass pyflakes:
./tests/samplingTests.py:30: 'libvirtconnection' imported but unused ./tests/samplingTests.py:36: 'MonkeyPatch' imported but unused make: *** [pyflakes] Error 1
You could clearly see that the tests did not pass for patchset #6 Please do not merge patches with failing tests!
Barak, thanks for reporting this mistake of ours. https://gerrit.ovirt.org/#/c/40408/ would fix it momentarily.
I believe that it stems from two reasons: - Ido did not run `make check` or `make pyflakes` before ticking "verified" on the patch - I failed to wait for the jenkins job to finish.
To make sure that this does not repeat I should avoid merging freshly-posted patches. Ido should take better care for pep8 and pyflakes. I have vim plugins that help me avoid such mistakes I hear that http://www.vim.org/scripts/script.php?script_id=4440 is better than what I actually have.
Regards, Dan.
---end quoted text--- -- Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization R&D Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060 --VrqPEDrXMn8OVzN4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVR+1wAAoJEG1jOVLJoOfYVmgQAIr7GLoawCk+M6lujyBldpgt ooU4JgyB5IyCAWtvYSXdslTNkkzQOLuv+JKjBZfWbsc/EviCbF1z9J/9UaB+d0wj guuWRmEgX6P1Y/gne61VeQskXZVGhogR35gtUm3FtVqM9kJeD8TDZ4o+E0Cs6rCh 1jZRJVCFtdKlUJoTucBX6Tfb2xb9wxwNmQNqs6huhh9FP7DmaTD2LOldNCkmtvJP +KKNUTSM6BcoWNz89TpDWfNTAUTgj71Wfdmt+BFn3ucUapRkuYfNFgHSJHjlppBQ YXc8I978mD35VJc8amukMz6nxosRJXlaLCuCuUvmzBmbFP8AErySVfIxLLv8SA09 nkC7L0KxVdWi/AaSpnSkanGIm0G7VficBoZV4WQ+0rL0BjFJVCONHo+T1QNeOV5d M9lSfzJAG/fx6aBT6XbxyAT0ojws4SKziuDemucTh1nzm4dLg07/GKGeEsoHPt4y BJNvkkwEVvWs97ucFAhAmYCtkuclFjRQOx/I3D+yctryEETTMAEXIpYiJVn+PTrF GsgASR5Hf+c4V7/99WD/Dt0qYfxr1VuAqjYKJsh+sEcgZbaiubsTzcKK/S6hmSQQ 1vEuIOAKeER1l/dL00SFnO8rPGU34ZXQK7yXREI7O4/WOalPs1jS6jk0/b8QBZeY LZojwdHrBAN+WE+pSvHK =tS1O -----END PGP SIGNATURE----- --VrqPEDrXMn8OVzN4--