Re: your patch https://gerrit.ovirt.org/#/c/40346/ broke oVirt vdsm jobs

--VrqPEDrXMn8OVzN4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline hi, Dan. makes sense to me to focus on 2 use cases: - pre-commit hook running everything jenkins is running - locally - pros: - nearly identical checks/tests jenkins would running - doesn't care about IDE/editor - cons: - slower - can be annoying to commit (locally) broken code for later squashing - editor/IDE marriage with tests/checks running - pros: - dev has full control over what runs in checks/tests - allows to commit "dirty" commit - shorter ==> quicker than the quickest jenkins option - cons: - depends on IDE/editor support - less checks/tests => higher risk I did both with: intelliJ/PyCharm and vim, almost 100% sure PyDev allows this. either allows ease of running tests - in 1st case upon git commit, in the latter - via a button/shortcut in the devtool. I can help with setting up either to an early adopter. Then give it a week or two to get some feedback later how well it goes. Besides, we're also trying to speedup jenkins response all the time WDYT? On Wed, Apr 29, 2015 at 10:57:14PM +0100, Dan Kenigsberg wrote: ---end quoted text--- -- Max Kovgan Senior Software Engineer Red Hat - EMEA ENG Virtualization R&D Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060 --VrqPEDrXMn8OVzN4 Content-Type: application/pgp-signature --VrqPEDrXMn8OVzN4--