Running arquillian tests on gerrit reviews
Hi, Recently we merged some patches which can run arquillian unit tests with a database (this means running ovirt commands without mocking and working injections). They do a commit rollback after each test in the db like th DAO tests: https://gerrit.ovirt.org/#/q/status:merged+project:ovirt-engine+branch:maste... I am wondering if we can include them in the jenkins/gerrit flow. They can be executed like this: mvn clean verify -DskipITs=false This command also makes sure that the database is up to date by applying the database scripts. Would be glad to get some feedback on how to integrate them in our CI flows. Roman
--jCrbxBqMcLqd4mOl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 06/15 14:36, Roman Mohr wrote:
Hi, =20 Recently we merged some patches which can run arquillian unit tests with a database (this means running ovirt commands without mocking and working injections). They do a commit rollback after each test in the db like th DAO tests: =20 https://gerrit.ovirt.org/#/q/status:merged+project:ovirt-engine+branch:ma= ster+topic:integration =20 I am wondering if we can include them in the jenkins/gerrit flow. They can be executed like this: =20 mvn clean verify -DskipITs=3Dfalse =20 This command also makes sure that the database is up to date by applying the database scripts. =20 Would be glad to get some feedback on how to integrate them in our CI flo= ws.
To do so you just have to add that command to the automation/check-patch.sh script in the ovirt-engine git repo (you should also fail if it fails and s= uch)
=20 Roman _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --jCrbxBqMcLqd4mOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXYUxlAAoJEEBxx+HSYmnDIXYH/A1hWrCJXdANBdNBELPWAIJA nK7m+XrVmF16ahsnoU5yjxujQB5Io6TYIS47pyTBE91c0GMJJebNhErL4rZPTUEP 5teac/2VSMqHzo5K1i2FFH3QjOmlugMsZKSBmD7lTkUdUXIzHvVgWB6xdlbkrTNU mv7CoWziuuB3vfoevaPRAsajKpHREZ3iU9TKyrgD+a2/cECuTTWJN0CsVmWtF9Zy bI43+DIVcmOpVfUAJF1ztozsDKn76Uf1ZiYNP3xNyKzVF5os4z8QADrxDh8jZDn9 T/RZY7e3lcd00u0WPNudm3HM76sAxYKOk2T7baYZPf8Ob5/IzgzoZYa21RlTPnA= =K9eG -----END PGP SIGNATURE----- --jCrbxBqMcLqd4mOl--
Would be glad to get some feedback on how to integrate them in our CI flows.
To do so you just have to add that command to the automation/check-patch.sh script in the ovirt-engine git repo (you should also fail if it fails and such)
You should probably also make sure to integrate this with recent work by 'gshinar' that adds the postgres setup (and DAO tests) to check_patch.sh. -- Barak Korren bkorren@redhat.com RHEV-CI Team
see https://gerrit.ovirt.org/#/c/58663/ On Wed, Jun 15, 2016 at 3:56 PM, Barak Korren <bkorren@redhat.com> wrote:
Would be glad to get some feedback on how to integrate them in our CI
flows.
To do so you just have to add that command to the automation/check-patch.sh script in the ovirt-engine git repo (you should also fail if it fails and such)
You should probably also make sure to integrate this with recent work by 'gshinar' that adds the postgres setup (and DAO tests) to check_patch.sh.
-- Barak Korren bkorren@redhat.com RHEV-CI Team
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Wed, Jun 15, 2016 at 3:27 PM, Eyal Edri <eedri@redhat.com> wrote:
see https://gerrit.ovirt.org/#/c/58663/
On Wed, Jun 15, 2016 at 3:56 PM, Barak Korren <bkorren@redhat.com> wrote:
Would be glad to get some feedback on how to integrate them in our CI flows.
To do so you just have to add that command to the automation/check-patch.sh script in the ovirt-engine git repo (you should also fail if it fails and such)
You should probably also make sure to integrate this with recent work by 'gshinar' that adds the postgres setup (and DAO tests) to check_patch.sh.
-- Barak Korren bkorren@redhat.com RHEV-CI Team
Thx for the pointers. That are good enough starting point for me :) Roman
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
participants (4)
-
Barak Korren -
David Caro Estevez -
Eyal Edri -
Roman Mohr