[Infra] Jenkins: Possible wrong configuration of the job vdsm_unit_tests_manual_gerrit
Hi, This job is for running unit test on new patches submit to gerrit.ovirt.org. I found every time this job runs, it just checkout the origin/master of vdsm, but not the submitted patch. For example, In http://gerrit.ovirt.org/#/c/9315/ the commit hash of patch set 2 is 0fca07f9526c, but in the related build http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/71/console The log says it Checking out Revision a7b2577107c5b30b4078ead37717d2176693143d (origin/master) And you can see the same problem in http://gerrit.ovirt.org/#/c/9346/ and http://gerrit.ovirt.org/#/c/9345/ These two are different patches, but the related build at http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/console http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/79/console all do the same checkout as said in the log. Checking out Revision 2c0fd0796ad6ac7132340016198d30519c71bc8f (origin/master) Since commit 2c0fd079 of the current origin master contains a bug, it can not pass the build process so the above two patches get a verify failure comment by Jenkins. What's worse, if the current master is good and some patches got bugs, Jenkins will not find out those bug and happily give +1 as verify comment. Could you check the job configuration? Maybe you can examine the advanced settings of the git repository configuration and check if Refspec is $GERRIT_REFSPEC, Branch Specifier is $GERRIT_BRANCH, and examine the gerrit trigger to check if branch pattern is **. These settings works for me, I hope it can help you a little bit. -- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
Correct. job was mis-configured and fixed now. 1. refspec for vdsm should be $GERRIT_REFSPEC (was none) 2. strategy (of git plugin) should be 'gerrit trigger' and not default. both are now fixed, please check now if it's according to the patch. also, new plugin features allows triggering the job according to various actions in the patch: Specify what type of event(s) to trigger on: Draft Published: Sent when a change moves from draft state to new. (only available in version 2.5 or higher of Gerrit). Patchset Created: Sent when a new patchset arrives on a change. Before version 2.6.0, this was the only event you could trigger on. Change Merged: Sent when a change is merged on the Gerrit server. Comment Added: Sent when a comment is added to a change. Which category and value to trigger on can be configured. The available categories can be configured in the server settings for the plugin. Ref Updated: Sent when a ref is updated on the Gerrit server, i.e. someone pushes past code review. currently it's set on 'Patchset Created'. thanks for notifying on this! Eyal Edri oVirt Infra Team. ----- Original Message -----
From: "Zhou Zheng Sheng" <zhshzhou@linux.vnet.ibm.com> To: infra@ovirt.org, "Dan Kenigsberg" <danken@redhat.com> Sent: Tuesday, November 20, 2012 9:45:29 AM Subject: [Infra] Jenkins: Possible wrong configuration of the job vdsm_unit_tests_manual_gerrit
Hi,
This job is for running unit test on new patches submit to gerrit.ovirt.org. I found every time this job runs, it just checkout the origin/master of vdsm, but not the submitted patch.
For example, In
http://gerrit.ovirt.org/#/c/9315/
the commit hash of patch set 2 is 0fca07f9526c, but in the related build
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/71/console
The log says it
Checking out Revision a7b2577107c5b30b4078ead37717d2176693143d (origin/master)
And you can see the same problem in
http://gerrit.ovirt.org/#/c/9346/
and
http://gerrit.ovirt.org/#/c/9345/
These two are different patches, but the related build at http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/console http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/79/console all do the same checkout as said in the log.
Checking out Revision 2c0fd0796ad6ac7132340016198d30519c71bc8f (origin/master)
Since commit 2c0fd079 of the current origin master contains a bug, it can not pass the build process so the above two patches get a verify failure comment by Jenkins. What's worse, if the current master is good and some patches got bugs, Jenkins will not find out those bug and happily give +1 as verify comment.
Could you check the job configuration? Maybe you can examine the advanced settings of the git repository configuration and check if Refspec is $GERRIT_REFSPEC, Branch Specifier is $GERRIT_BRANCH, and examine the gerrit trigger to check if branch pattern is **. These settings works for me, I hope it can help you a little bit.
-- Thanks and best regards!
Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Thanks Eyal, it works well now. on 11/20/2012 16:08, Eyal Edri wrote:
Correct.
job was mis-configured and fixed now.
1. refspec for vdsm should be $GERRIT_REFSPEC (was none) 2. strategy (of git plugin) should be 'gerrit trigger' and not default.
both are now fixed, please check now if it's according to the patch.
also, new plugin features allows triggering the job according to various actions in the patch:
Specify what type of event(s) to trigger on:
Draft Published: Sent when a change moves from draft state to new. (only available in version 2.5 or higher of Gerrit). Patchset Created: Sent when a new patchset arrives on a change. Before version 2.6.0, this was the only event you could trigger on. Change Merged: Sent when a change is merged on the Gerrit server. Comment Added: Sent when a comment is added to a change. Which category and value to trigger on can be configured. The available categories can be configured in the server settings for the plugin. Ref Updated: Sent when a ref is updated on the Gerrit server, i.e. someone pushes past code review.
currently it's set on 'Patchset Created'.
thanks for notifying on this!
Eyal Edri oVirt Infra Team.
----- Original Message -----
From: "Zhou Zheng Sheng" <zhshzhou@linux.vnet.ibm.com> To: infra@ovirt.org, "Dan Kenigsberg" <danken@redhat.com> Sent: Tuesday, November 20, 2012 9:45:29 AM Subject: [Infra] Jenkins: Possible wrong configuration of the job vdsm_unit_tests_manual_gerrit
Hi,
This job is for running unit test on new patches submit to gerrit.ovirt.org. I found every time this job runs, it just checkout the origin/master of vdsm, but not the submitted patch.
For example, In
http://gerrit.ovirt.org/#/c/9315/
the commit hash of patch set 2 is 0fca07f9526c, but in the related build
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/71/console
The log says it
Checking out Revision a7b2577107c5b30b4078ead37717d2176693143d (origin/master)
And you can see the same problem in
http://gerrit.ovirt.org/#/c/9346/
and
http://gerrit.ovirt.org/#/c/9345/
These two are different patches, but the related build at http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/80/console http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/79/console all do the same checkout as said in the log.
Checking out Revision 2c0fd0796ad6ac7132340016198d30519c71bc8f (origin/master)
Since commit 2c0fd079 of the current origin master contains a bug, it can not pass the build process so the above two patches get a verify failure comment by Jenkins. What's worse, if the current master is good and some patches got bugs, Jenkins will not find out those bug and happily give +1 as verify comment.
Could you check the job configuration? Maybe you can examine the advanced settings of the git repository configuration and check if Refspec is $GERRIT_REFSPEC, Branch Specifier is $GERRIT_BRANCH, and examine the gerrit trigger to check if branch pattern is **. These settings works for me, I hope it can help you a little bit.
-- Thanks and best regards!
Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail: zhshzhou@linux.vnet.ibm.com Telephone: 86-10-82454397
participants (2)
-
Eyal Edri -
Zhou Zheng Sheng