[VDSM] vdsm_master_verify-error-codes_created running on master - why?
Hi all, Since yesterday, vdsm_master_verify-error-codes_created job is running on master. I guess that this was a unintended change in jenkins - please revert this change. If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first. The best would be to run everything from the automation scripts, so vdsm maintainers have full control on the way patches are checked. Thanks, Nir
This isn't new, it was running for a few years, just on old jenkins, Maybe you just noticed it. Allon & Dan are familiar with that job and it already found in the past real issues. If you want to remove/disable it, I have no problem - just make sure you're synced with all VDSM people that requested this job in the first place. On Tue, Jul 19, 2016 at 6:02 PM, Nir Soffer <nsoffer@redhat.com> wrote:
Hi all,
Since yesterday, vdsm_master_verify-error-codes_created job is running on master.
I guess that this was a unintended change in jenkins - please revert this change.
If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first.
The best would be to run everything from the automation scripts, so vdsm maintainers have full control on the way patches are checked.
Thanks, Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
And also, feel free to move it to check-patch.sh code as well. On Tue, Jul 19, 2016 at 6:19 PM, Eyal Edri <eedri@redhat.com> wrote:
This isn't new, it was running for a few years, just on old jenkins, Maybe you just noticed it.
Allon & Dan are familiar with that job and it already found in the past real issues. If you want to remove/disable it, I have no problem - just make sure you're synced with all VDSM people that requested this job in the first place.
On Tue, Jul 19, 2016 at 6:02 PM, Nir Soffer <nsoffer@redhat.com> wrote:
Hi all,
Since yesterday, vdsm_master_verify-error-codes_created job is running on master.
I guess that this was a unintended change in jenkins - please revert this change.
If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first.
The best would be to run everything from the automation scripts, so vdsm maintainers have full control on the way patches are checked.
Thanks, Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Tue, Jul 19, 2016 at 6:20 PM, Eyal Edri <eedri@redhat.com> wrote:
And also, feel free to move it to check-patch.sh code as well.
Including this in vdsm seem like the best option. Can you point me to the source of this job?
On Tue, Jul 19, 2016 at 6:19 PM, Eyal Edri <eedri@redhat.com> wrote:
This isn't new, it was running for a few years, just on old jenkins, Maybe you just noticed it.
Allon & Dan are familiar with that job and it already found in the past real issues. If you want to remove/disable it, I have no problem - just make sure you're synced with all VDSM people that requested this job in the first place.
On Tue, Jul 19, 2016 at 6:02 PM, Nir Soffer <nsoffer@redhat.com> wrote:
Hi all,
Since yesterday, vdsm_master_verify-error-codes_created job is running on master.
I guess that this was a unintended change in jenkins - please revert this change.
If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first.
The best would be to run everything from the automation scripts, so vdsm maintainers have full control on the way patches are checked.
Thanks, Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
It wasn't yamelized until recently, so you can see the open patch for it at [1]. I guess you can checkout the patch to jenkins repo and take the script from there. If you're moving it to vdsm repo, I'll abandon this patch, please let me know. [1] https://gerrit.ovirt.org/#/c/60630/2 On Wed, Jul 20, 2016 at 1:51 AM, Nir Soffer <nsoffer@redhat.com> wrote:
On Tue, Jul 19, 2016 at 6:20 PM, Eyal Edri <eedri@redhat.com> wrote:
And also, feel free to move it to check-patch.sh code as well.
Including this in vdsm seem like the best option.
Can you point me to the source of this job?
On Tue, Jul 19, 2016 at 6:19 PM, Eyal Edri <eedri@redhat.com> wrote:
This isn't new, it was running for a few years, just on old jenkins, Maybe you just noticed it.
Allon & Dan are familiar with that job and it already found in the past real issues. If you want to remove/disable it, I have no problem - just make sure you're synced with all VDSM people that requested this job in the first place.
On Tue, Jul 19, 2016 at 6:02 PM, Nir Soffer <nsoffer@redhat.com> wrote:
Hi all,
Since yesterday, vdsm_master_verify-error-codes_created job is running on master.
I guess that this was a unintended change in jenkins - please revert
this
change.
If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first.
The best would be to run everything from the automation scripts, so vdsm maintainers have full control on the way patches are checked.
Thanks, Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Wed, Jul 20, 2016 at 01:51:51AM +0300, Nir Soffer wrote:
On Tue, Jul 19, 2016 at 6:20 PM, Eyal Edri <eedri@redhat.com> wrote:
And also, feel free to move it to check-patch.sh code as well.
Including this in vdsm seem like the best option.
Can you point me to the source of this job?
On Tue, Jul 19, 2016 at 6:19 PM, Eyal Edri <eedri@redhat.com> wrote:
This isn't new, it was running for a few years, just on old jenkins, Maybe you just noticed it.
Allon & Dan are familiar with that job and it already found in the past real issues. If you want to remove/disable it, I have no problem - just make sure you're synced with all VDSM people that requested this job in the first place.
On Tue, Jul 19, 2016 at 6:02 PM, Nir Soffer <nsoffer@redhat.com> wrote:
Hi all,
Since yesterday, vdsm_master_verify-error-codes_created job is running on master.
I guess that this was a unintended change in jenkins - please revert this change.
If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first.
The best would be to run everything from the automation scripts, so vdsm maintainers have full control on the way patches are checked.
A bit of a background: this job was created many many years ago, in order to compare the set of error codes in Vdsm to that of Engine. The motivation was to catch typos or other mismatches, where Vdsm is sending one value and Engine is expecting another, or Vdsm dropping something that Engine depends on. HOWEVER, I'm not sure at all that the job's code is up-to-date. I wonder how it could have every survived the big changes of https://gerrit.ovirt.org/#/c/48871/ and its bash code http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/configure does not reassure me
participants (3)
-
Dan Kenigsberg -
Eyal Edri -
Nir Soffer