From: "Eyal Edri" <eedri(a)redhat.com&gt; To: "Nir Soffer" <nsoffer(a)redhat.com&gt; Cc: "infra" <infra(a)ovirt.org&gt;, "Vered Volansky" <vvolansk(a)redhat.com&gt;, "Dan Kenigsberg" <danken(a)redhat.com&gt; Sent: Thursday, June 12, 2014 2:37:33 PM Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit we're not maintaining the functional tests code in jenkins, i believe it's vered. vered - do you need any help with refactoring this? eyal. ----- Original Message ----- > From: "Nir Soffer" <nsoffer(a)redhat.com&gt; > To: "infra" <infra(a)ovirt.org&gt;, "Vered Volansky" <vvolansk(a)redhat.com&gt;, "Dan > Kenigsberg" <danken(a)redhat.com&gt; > Sent: Wednesday, June 11, 2014 9:10:40 PM > Subject: Bad setup code in > vdsm_master_storage_functional_tests_localfs_gerrit > > Hi infra, > > I have seen this failure today: > > 16:52:35 Triggered by Gerrit: http://gerrit.ovirt.org/28610 > 16:52:35 Building remotely on dcaro-ovirt-vm02-fc20 (os1 fedora20) in > workspace > /home/jenkins/workspace/vdsm_master_storage_functional_tests_localfs_gerrit > ... > 16:53:00 + sudo sh -c 'echo "" > /var/log/vdsm/vdsm.log' > 16:53:00 sh: /var/log/vdsm/vdsm.log: No such file or directory > 16:53:02 Build step 'Execute shell' marked build as failure > > We need more robust code. Something like: > > vdsm_log="/var/log/vdsm/vdsm.log" > > if [ -f "$vdsm_log" ]; then > sudo sh -c 'echo "" > "$vdsm_log" > fi > > Thanks, > Nir > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra >

From: "Dan Kenigsberg" <danken(a)redhat.com&gt; To: "Vered Volansky" <vered(a)redhat.com&gt; Cc: "infra" <infra(a)ovirt.org&gt; Sent: Monday, June 16, 2014 11:29:42 AM Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit On Sun, Jun 15, 2014 at 04:11:53AM -0400, Vered Volansky wrote: > The job with this issue is gone, let me know if it's risen again. The fragile code is still in http://jenkins.ovirt.org/view/All/job/vdsm_master_storage_functional_test... why not make it more robust before /var/log/vdsm disappears and make it break again?

BTW, if /var/log/vdsm/vdsm.log is missing, the discussed line would create it owned by root, which would fail the startup of vdsm. Please use the vdsm user instead.

_______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

----- Original Message ----- > From: "Dan Kenigsberg" <danken(a)redhat.com&gt; > To: "Vered Volansky" <vered(a)redhat.com&gt; > Cc: "infra" <infra(a)ovirt.org&gt; > Sent: Monday, June 16, 2014 11:29:42 AM > Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit > > On Sun, Jun 15, 2014 at 04:11:53AM -0400, Vered Volansky wrote: > > The job with this issue is gone, let me know if it's risen again. > > The fragile code is still in > http://jenkins.ovirt.org/view/All/job/vdsm_master_storage_functional_test... > why not make it more robust before /var/log/vdsm disappears and make it > break again? because I don't understand the issue. The file is only created if missing. The directory should be there.

On Tue, Jun 17, 2014 at 03:40:51AM -0400, Vered Volansky wrote: > > > ----- Original Message ----- >> From: "Dan Kenigsberg" <danken(a)redhat.com&gt; >> To: "Vered Volansky" <vered(a)redhat.com&gt; >> Cc: "infra" <infra(a)ovirt.org&gt; >> Sent: Monday, June 16, 2014 11:29:42 AM >> Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_l=

>> >> On Sun, Jun 15, 2014 at 04:11:53AM -0400, Vered Volansky wrote: >>> The job with this issue is gone, let me know if it's risen again. >> >> The fragile code is still in >> http://jenkins.ovirt.org/view/All/job/vdsm_master_storage_functional_=

>> why not make it more robust before /var/log/vdsm disappears and make =

>> break again? > > because I don't understand the issue. The file is only created if > missing. The directory should be there.

However, apparently it was not there, which made the echo fail, which led to the job failing. We should understand why it disappeared. dcaro, eedri - do you have any idea?

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTn/1UAAoJEEBxx+HSYmnDgOkH/3elCRKZyw+SuTdrpTKKjeCJ q38TSjRMWUl+RG0sm13QfN3i+mADgrNScvzSXujQrETiFHZpa5tI5Jp9iuCUsYE9 36Q1NIOb5Te7dIa+IJBcbvc44L7KEKPBv0RFxsiQiMEv05K8FsaW1z3RuM0InlIC z8N5jYOFgbb2+4x9loWzT8+PkQgwptYX/VSGrgMB7Mpgeqy/40jq+NK9Wp+uMw51 LueNxdZwdP7Dr+SKg3xmJCv95Hygbl7DHgpiEECv3aCUZONCWuzBdULZURvSeLcn qwJ/zTTsd/ZSPFKopjvNGYWV0zBdvXXx6gHhTqmzwxEZpAo9IK47AHxIzrJy8K0= =8wxD -----END PGP SIGNATURE-----

On Tue 17 Jun 2014 10:24:49 AM CEST, Dan Kenigsberg wrote: > On Tue, Jun 17, 2014 at 03:40:51AM -0400, Vered Volansky wrote: >> >> >> ----- Original Message ----- >>> From: "Dan Kenigsberg" <danken(a)redhat.com&gt; >>> To: "Vered Volansky" <vered(a)redhat.com&gt; >>> Cc: "infra" <infra(a)ovirt.org&gt; >>> Sent: Monday, June 16, 2014 11:29:42 AM >>> Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_localfs_gerrit >>> >>> On Sun, Jun 15, 2014 at 04:11:53AM -0400, Vered Volansky wrote: >>>> The job with this issue is gone, let me know if it's risen again. >>> >>> The fragile code is still in >>> http://jenkins.ovirt.org/view/All/job/vdsm_master_storage_functional_test... >>> why not make it more robust before /var/log/vdsm disappears and make it >>> break again? >> >> because I don't understand the issue. The file is only created if >> missing. The directory should be there. It was fixed by me some time ago (I added the mkdir -p before the touch, just in case) sudo mkdir -p /var/log/vdsm sudo chown vdsm:kvm sudo sh -c 'echo "" > /var/log/vdsm/vdsm.log' sudo sh -c 'echo "" > /var/log/vdsm/supervdsm.log' > > However, apparently it was not there, which made the echo fail, which > led to the job failing. We should understand why it disappeared. > > dcaro, eedri - do you have any idea? Totally agree, and, if it was meant to be there, I'll remove the mkdir to make the test fail if it's not there. But for what I see on the job, there's nothing that ensures you that the directory will be there, vdsm might never have been installed on that machine, or might have been properly cleaned at some point (removing logs and leftovers). So, In my opinion the issue is that we are not cleaning up properly after the vdsm jobs and leaving the logs behind.