[JIRA] (OVIRT-2730) Running sub stages using https://jenkins.ovirt.org/job/standard-manual-runner/
[ https://ovirt-jira.atlassian.net/browse/OVIRT-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=39333#comment-39333 ] Barak Korren commented on OVIRT-2730: ------------------------------------- On Wed, 15 May 2019 at 18:58, Nir Soffer (oVirt JIRA) < Looking at the stdci.yaml file I get when cloning the patch - I don't see any substages or distroes defined in it, so STDCI does what it can in that case - run the default substage for the specified architectures that it can find script files for. Is this based on a very old version of vdsm's stdci.yaml ? You can see the exact same thing happening for check-patch triggered from Gerrit: https://jenkins.ovirt.org/blue/organizations/jenkins/vdsm_standard-check-pat... In fact running check-patch with manual runner is quite useless, since CI will always run it for you anyway when you push the patch... Because you can't select substages like that. check-network would not work since its not defined in stdci.yaml for that patch. It runs the exact same code. - allow selection of a sub stage? Probably not gonna happen - this would require some deep changes. - nice to have - allow selection of multiple sub stages Same as above, you can only select a stage at this point. -- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
Running sub stages using https://jenkins.ovirt.org/job/standard-manual-runner/ ------------------------------------------------------------------------------
Key: OVIRT-2730 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2730 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: Nir Soffer Assignee: infra
I tried to run check-patch and check-patch linters substage from the command line: using: https://github.com/nirs/oci/pull/37 I assumed that this will run the entire check-patch stage, including all the sub stages: ./ovirt-ci run -s check-patch 100007 But it run something that looks like check-patch with el7: https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/... The test environment seems to be different that what we have when check-patch is triggered from gerrit. Then I tried to run the linters substage: ./ovirt-ci run -s check-patch.linters 100007 https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/... ./ovirt-ci run -s check-patch.linters 100007 https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/... Both succeeded without running anything :-) Running build-artifacts works, not sure about check-network. Can we fix the manual job so: - it run exactly the same way as it run when gerrit trigger the job - allow selection of a sub stage? - nice to have - allow selection of multiple sub stages Nir
-- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100102)
On Thu, May 16, 2019 at 8:23 AM Barak Korren (oVirt JIRA) < jira@ovirt-jira.atlassian.net> wrote:
Barak Korren commented on OVIRT-2730: -------------------------------------
On Wed, 15 May 2019 at 18:58, Nir Soffer (oVirt JIRA) <
Looking at the stdci.yaml file I get when cloning the patch -
How do you test this?
I don't see any substages or distroes defined in it, so STDCI does what it can in that case - run the default substage for the specified architectures that it can find script files for.
Is this based on a very old version of vdsm's stdci.yaml ?
You can see the exact same thing happening for check-patch triggered from Gerrit:
https://jenkins.ovirt.org/blue/organizations/jenkins/vdsm_standard-check-pat...
In fact running check-patch with manual runner is quite useless, since CI will always run it for you anyway when you push the patch...
But CI is sometimes flaky, and we need to re-trigger a build. Using the command line tool is an easy way. However this was mainly testing the capabilities of the manual runner. I don't think many people will use check-patch from the command line. Because you can't select substages like that.
check-network would not work since its not defined in stdci.yaml for that patch.
Very strange, the patch I tested is was on master which has valid stdci.yaml. Here is another check-network build - seems to work correctly: https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/... I also did other 2 builds today, and they look normal: ./ovirt-ci run build-artifacts 98608 https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/... ./ovirt-ci run check-patch 98608 https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/... So running stages seems to work fine. It runs the exact same code.
- allow selection of a sub stage?
Probably not gonna happen - this would require some deep changes.
- nice to have - allow selection of multiple sub stages
Same as above, you can only select a stage at this point.
-- Barak Korren RHV DevOps team , RHCE, RHCi Red Hat EMEA redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
Running sub stages using https://jenkins.ovirt.org/job/standard-manual-runner/
------------------------------------------------------------------------------
Key: OVIRT-2730 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2730 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: Nir Soffer Assignee: infra
I tried to run check-patch and check-patch linters substage from the command line: using: https://github.com/nirs/oci/pull/37 I assumed that this will run the entire check-patch stage, including all the sub stages: ./ovirt-ci run -s check-patch 100007 But it run something that looks like check-patch with el7:
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
The test environment seems to be different that what we have when check-patch is triggered from gerrit. Then I tried to run the linters substage: ./ovirt-ci run -s check-patch.linters 100007
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
./ovirt-ci run -s check-patch.linters 100007
https://jenkins.ovirt.org/blue/organizations/jenkins/standard-manual-runner/...
Both succeeded without running anything :-) Running build-artifacts works, not sure about check-network. Can we fix the manual job so: - it run exactly the same way as it run when gerrit trigger the job - allow selection of a sub stage? - nice to have - allow selection of multiple sub stages Nir
-- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100102) _______________________________________________ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/66K6A5N3JKBMRO...
participants (2)
-
Barak Korren (oVirt JIRA) -
Nir Soffer