This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BiqR9cnB7IDE2sfOq9BtMg4X41CvwCcGO Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi! There are still some findbugs issues merged on ovirt-engine master, and I= 've tracked them down to a couple commits of yours, can you please review the= m and if they were introduced there, fix them? Thanks!! Commit 4c2d171a701c04f5b3a82690826aa72b08f2f3e1 by Martin Perina HostGeneralModel.java:641, ES_COMPARING_PARAMETER_STRING_WITH_EQ, Priorit= y: Low Comparison of String parameter using =3D=3D or !=3D in org.ovirt.engine.ui.uicommonweb.models.hosts.HostGeneralModel.setKdumpSta= tus(String) This code compares a java.lang.String parameter for reference equality us= ing the =3D=3D or !=3D operators. Requiring callers to pass only String constants= or interned strings to a method is unnecessarily fragile, and rarely leads to measura= ble performance gains. Consider using the equals(Object) method instead. Commit 749eba95219f36c0ad5ee8216b65a8efc8a1bae4 by Tomas Jelinek VmListModel.java:424, URF_UNREAD_FIELD, Priority: Low Unread field: org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.privateCustomPrope= rtiesKeysList This field is never read. Consider removing it from the class. pd. We have improved infra enough and we are gonna enable back the per-pa= tch checks to avoid this from happening in the future so we will not bother y= ou anymore with these issues :) --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --BiqR9cnB7IDE2sfOq9BtMg4X41CvwCcGO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTV+XbAAoJEEBxx+HSYmnDICoH/j6Q2kjINQXSx30EuxIj8aE4 InsSCJtQ0+wdvD2LK63ddMlgK99w5rgEmftvHIz20J0SwQiNoMFjCBDVqP6c3tDn G/iz3rtzuz5+G22SEY5bHFdQrD8tMQu57HEErbRXBuaBxVksjl9dB0PLeSVt9q8P PBLa9TQ+qYr9/ALUn4gSGCfKYG/aK/tszjwOD8IFPxtaRo9CNe5Nk9G2sJImSGHj pMYhZ09tHhsVJdOrgMfqtRSd+2XMxQPUr8jO/zQeGVQsP7fFb6LhpqfKdvZ/hLEM 4mUISnf80EsfADTBSiZrrMn2U4K0wWMox64uMtE/aIosh3KeSMyHJJROpXTnRfE= =9K9t -----END PGP SIGNATURE----- --BiqR9cnB7IDE2sfOq9BtMg4X41CvwCcGO--
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com>, "Martin Perina" <mperina@redhat.com>, "infra" <infra@ovirt.org> Sent: Wednesday, April 23, 2014 6:10:03 PM Subject: Findbugs issues
Hi!
There are still some findbugs issues merged on ovirt-engine master, and I've tracked them down to a couple commits of yours, can you please review them and if they were introduced there, fix them?
Thanks!!
Commit 4c2d171a701c04f5b3a82690826aa72b08f2f3e1 by Martin Perina HostGeneralModel.java:641, ES_COMPARING_PARAMETER_STRING_WITH_EQ, Priority: Low
Comparison of String parameter using == or != in org.ovirt.engine.ui.uicommonweb.models.hosts.HostGeneralModel.setKdumpStatus(String)
This code compares a java.lang.String parameter for reference equality using the == or != operators. Requiring callers to pass only String constants or interned strings to a method is unnecessarily fragile, and rarely leads to measurable performance gains. Consider using the equals(Object) method instead.
Sorry, I missed this. Patch is ready: http://gerrit.ovirt.org/#/c/27022/ Martin
Commit 749eba95219f36c0ad5ee8216b65a8efc8a1bae4 by Tomas Jelinek VmListModel.java:424, URF_UNREAD_FIELD, Priority: Low
Unread field: org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.privateCustomPropertiesKeysList
This field is never read. Consider removing it from the class.
pd. We have improved infra enough and we are gonna enable back the per-patch checks to avoid this from happening in the future so we will not bother you anymore with these issues :)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
merged ----- Original Message -----
From: "Martin Perina" <mperina@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "Tomas Jelinek" <tjelinek@redhat.com>, "infra" <infra@ovirt.org> Sent: Wednesday, April 23, 2014 6:34:55 PM Subject: Re: Findbugs issues
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Tomas Jelinek" <tjelinek@redhat.com>, "Martin Perina" <mperina@redhat.com>, "infra" <infra@ovirt.org> Sent: Wednesday, April 23, 2014 6:10:03 PM Subject: Findbugs issues
Hi!
There are still some findbugs issues merged on ovirt-engine master, and I've tracked them down to a couple commits of yours, can you please review them and if they were introduced there, fix them?
Thanks!!
Commit 4c2d171a701c04f5b3a82690826aa72b08f2f3e1 by Martin Perina HostGeneralModel.java:641, ES_COMPARING_PARAMETER_STRING_WITH_EQ, Priority: Low
Comparison of String parameter using == or != in org.ovirt.engine.ui.uicommonweb.models.hosts.HostGeneralModel.setKdumpStatus(String)
This code compares a java.lang.String parameter for reference equality using the == or != operators. Requiring callers to pass only String constants or interned strings to a method is unnecessarily fragile, and rarely leads to measurable performance gains. Consider using the equals(Object) method instead.
Sorry, I missed this. Patch is ready:
http://gerrit.ovirt.org/#/c/27022/
Martin
Commit 749eba95219f36c0ad5ee8216b65a8efc8a1bae4 by Tomas Jelinek VmListModel.java:424, URF_UNREAD_FIELD, Priority: Low
Unread field: org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.privateCustomPropertiesKeysList
This field is never read. Consider removing it from the class.
pd. We have improved infra enough and we are gonna enable back the per-patch checks to avoid this from happening in the future so we will not bother you anymore with these issues :)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
participants (3)
-
David Caro -
Martin Perina -
Tomas Jelinek