error in gerrit review

I get a "500 Internal server error" under "Conflicts with" tab [image: Inline image 1]

On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work: "status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master" is wrongly url-encoded twice to https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l... and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'" Is it a know gerrit bug? Is there a fix? Dan.

anton, can you check? e. On Mon, Oct 19, 2015 at 11:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
Dan. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Supervisor, RHEV CI EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

Hello Dan. Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment. Anton. On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat

Anton the 500 error is still there for me. I also bumped into the same issue as Dan On Mon, Oct 19, 2015 at 11:51 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Dan.
Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment.
Anton.
On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat

Hello Roy. This one I see. Checking. Anton. On Mon, Oct 19, 2015 at 10:53 AM, Roy Golan <rgolan@redhat.com> wrote:
Anton the 500 error is still there for me. I also bumped into the same issue as Dan
On Mon, Oct 19, 2015 at 11:51 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Dan.
Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment.
Anton.
On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat

Hello Roy. This looks to be a gerrit bug, I see java.lang.NullPointerException in the logs. Are you still able to do reviews/rebase the change, etc? I am trying to understand severity so we can plan upgrade. Anton. On Mon, Oct 19, 2015 at 11:03 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Roy.
This one I see. Checking.
Anton.
On Mon, Oct 19, 2015 at 10:53 AM, Roy Golan <rgolan@redhat.com> wrote:
Anton the 500 error is still there for me. I also bumped into the same issue as Dan
On Mon, Oct 19, 2015 at 11:51 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Dan.
Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment.
Anton.
On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat

On Mon, Oct 19, 2015 at 12:07 PM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Roy.
This looks to be a gerrit bug, I see java.lang.NullPointerException in the logs. Are you still able to do reviews/rebase the change, etc? I am trying to understand severity so we can plan upgrade.
Do you plan to upgrade to 2.11 soon? they allow editing the review code in place which will really shorten dev time
Anton.
On Mon, Oct 19, 2015 at 11:03 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Roy.
This one I see. Checking.
Anton.
On Mon, Oct 19, 2015 at 10:53 AM, Roy Golan <rgolan@redhat.com> wrote:
Anton the 500 error is still there for me. I also bumped into the same issue as Dan
On Mon, Oct 19, 2015 at 11:51 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Dan.
Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment.
Anton.
On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat

If there is an alternative, like restarting gerrit i prefer doing it and not upgrading gerrit just before ovirt GA. itamar, thought? e. On Mon, Oct 19, 2015 at 4:29 PM, Roy Golan <rgolan@redhat.com> wrote:
On Mon, Oct 19, 2015 at 12:07 PM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Roy.
This looks to be a gerrit bug, I see java.lang.NullPointerException in the logs. Are you still able to do reviews/rebase the change, etc? I am trying to understand severity so we can plan upgrade.
Do you plan to upgrade to 2.11 soon? they allow editing the review code in place which will really shorten dev time
Anton.
On Mon, Oct 19, 2015 at 11:03 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Roy.
This one I see. Checking.
Anton.
On Mon, Oct 19, 2015 at 10:53 AM, Roy Golan <rgolan@redhat.com> wrote:
Anton the 500 error is still there for me. I also bumped into the same issue as Dan
On Mon, Oct 19, 2015 at 11:51 AM, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello Dan.
Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment.
Anton.
On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote: > I get a "500 Internal server error" under "Conflicts with" tab >
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
and ends with a "Code Review - Error line 1:39 no viable alternative at character '%'"
Is it a know gerrit bug? Is there a fix?
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Supervisor, RHEV CI EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

On Mon, Oct 19, 2015 at 10:51:58AM +0200, Anton Marchukov wrote:
Hello Dan.
Can you confirm that it is still reproducible for you now? I hit the link and also tried that search filter and it works at the moment.
Anton.
On Mon, Oct 19, 2015 at 10:20 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote:
I get a "500 Internal server error" under "Conflicts with" tab
It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work:
"status:open project:vdsm label:verified+1 label:code-review>=+1 -label:code-review<=-1 branch:master"
is wrongly url-encoded twice to
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B1+l...
This still reproduces on my Firefox 41.0.1. I see no problem on Chrome.

--ibTvN161/egqYuK8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I've just restarted gerrit, can you check if the issues still persists? On 10/19, Dan Kenigsberg wrote:
I get a "500 Internal server error" under "Conflicts with" tab =20 =20 It smells unrelated, but recently I've noticed that my favorite gerrit search no longer work: =20 "status:open project:vdsm label:verified+1 label:code-review>=3D+1 -lab= el:code-review<=3D-1 branch:master" =20 is wrongly url-encoded twice to =20 https://gerrit.ovirt.org/#/q/status:open+project:vdsm+label:verified%252B= 1+label:code-review%253E%253D%252B1+-label:code-review%253C%253D-1+branch:m= aster =20 and ends with a "Code Review - Error
On Sun, Oct 18, 2015 at 04:29:02PM +0300, Roy Golan wrote: line 1:39 no viable alternative at character '%'" =20 Is it a know gerrit bug? Is there a fix? =20 Dan. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --ibTvN161/egqYuK8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWKgCPAAoJEEBxx+HSYmnDrAQH/i8kLaYrmmh9ON+PRfmgQVpz HpHGM5mEaJwJcXyjfMSLgExYKTsLnTJ6+AUQkMOqs07Iw94gg/2iPE/+2fXnqL0q bPrIcHb5n+NfLbbJWm6bIfy+d5ZOeZjqhEpp5bWISiPoyUkH+QZRhxTa2GMM9RLT EqZL3+PEHscKflYoIxM++CzU8X/YAwa3MPQF/iSz+m45ehyQ5L9oRLs/fyEUH0ti 3I1RFce6/Cs2CSLhHEoUOYs8T1mnSiakY+mLABqwqAYHQGiCJhr9DrNaPDvoqwQK r1kYYFOT6ab+oj3cvwATmXqsITAjMQ11aVJJCFOsVefMB/HE7N2rXA9oMw1yvVo= =B0Pn -----END PGP SIGNATURE----- --ibTvN161/egqYuK8--

On Fri, Oct 23, 2015 at 11:40:31AM +0200, David Caro wrote:
I've just restarted gerrit, can you check if the issues still persists?
It does, no improvement. https://gerrit.ovirt.org/#/q/project:vdsm+status:open+owner:%22Dan+Kenigsber...

i see this normally, so it might mean something is wrong with your user, which user to use to log in? e. On Sun, Oct 25, 2015 at 9:05 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Fri, Oct 23, 2015 at 11:40:31AM +0200, David Caro wrote:
I've just restarted gerrit, can you check if the issues still persists?
It does, no improvement.
https://gerrit.ovirt.org/#/q/project:vdsm+status:open+owner:%22Dan+Kenigsber...
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Supervisor, RHEV CI EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

On Sun, Oct 25, 2015 at 09:23:08AM +0100, Eyal Edri wrote:
i see this normally, so it might mean something is wrong with your user, which user to use to log in?
No, it's not something sepecific to me. The link bellow was generated by gerrit, and it is buggy. It contains the sequence "%253C" which is a double url-enconding of "<". Somehow this affects Firefox and not Chrome.
e.
On Sun, Oct 25, 2015 at 9:05 AM, Dan Kenigsberg <danken@redhat.com> wrote:
On Fri, Oct 23, 2015 at 11:40:31AM +0200, David Caro wrote:
I've just restarted gerrit, can you check if the issues still persists?
It does, no improvement.
https://gerrit.ovirt.org/#/q/project:vdsm+status:open+owner:%22Dan+Kenigsber...

--oC1+HKm2/end4ao3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Looks like a mix of gerrit and apache issue, gerrit requires for some urls = to get encoded, but it seems that in the case of searches it already encodes t= hem itself and apache reencodes a second time, will need some time to investiga= te and probably mess up a bit the ui while doing it. On 10/25, Dan Kenigsberg wrote:
On Sun, Oct 25, 2015 at 09:23:08AM +0100, Eyal Edri wrote:
i see this normally, so it might mean something is wrong with your user, which user to use to log in? =20 No, it's not something sepecific to me. The link bellow was generated by gerrit, and it is buggy. It contains the sequence "%253C" which is a double url-enconding of "<". =20 Somehow this affects Firefox and not Chrome. =20 =20 e. =20 On Sun, Oct 25, 2015 at 9:05 AM, Dan Kenigsberg <danken@redhat.com> wro= te: =20
On Fri, Oct 23, 2015 at 11:40:31AM +0200, David Caro wrote:
I've just restarted gerrit, can you check if the issues still persi= sts?
It does, no improvement.
https://gerrit.ovirt.org/#/q/project:vdsm+status:open+owner:%22Dan+Ke= nigsberg+%253Cdanken%2540redhat.com%253E%22
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --oC1+HKm2/end4ao3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWLehHAAoJEEBxx+HSYmnDtnoH/RVgI2MvV9zfsOI04ZX9NYM1 Y+hxNyTcrgLR8N+fOI6xbBMQIjbv0cs/LOe30+cTEfgjmLbldVbAnULRKB10f3oK raWpXql8bgq5h+Xi7TUBF2/McX80eFDbHwGjsfECySbUA5/19DldQ/i6w1/UKkMT CX3EgPysg+oZLGbXG2M9KiCDOCAfsIISfpkTpqaloz0xz+tIJkVekUIkKUIdk6GE IQGKP1V207e475E5DqL+IcItl4VAtBJmiCCQo3rj7ielxa1B9Xn6AnvfFdixAqf4 p8Le1jgF9JiU9SMDXcNTJsjeRrCW7xmO7PpaBGRUxiFeLoJxE4fAeOuaJc06ytk= =jqNt -----END PGP SIGNATURE----- --oC1+HKm2/end4ao3--
participants (5)
-
Anton Marchukov
-
Dan Kenigsberg
-
David Caro
-
Eyal Edri
-
Roy Golan