Re: [ovirt-devel] Failing MacPoolDaoTests on master
David, can you investigate? On May 31, 2016 12:29 PM, "Roman Mohr" <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 11:21 AM, Eyal Edri <eedri@redhat.com> wrote:
they only run on changes in :
**/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/**
**sql **/backend/manager/modules/dal/**
So where are the jobs for for https://gerrit.ovirt.org/#/c/58328/ for instance? They should have been triggered, right?
excluding file **/backend/manager/modules/dal/src/main/resources/bundles/**
On Tue, May 31, 2016 at 12:15 PM, Roman Mohr <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 11:12 AM, Eyal Edri <eedri@redhat.com> wrote:
the dao tests 4.0 are on the new jenkins and they are running:
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/ http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_created/
Am I missing somehting here? From my perspective it looks like they are never triggered.
the old one in old jenkins should be deleted.
On Tue, May 31, 2016 at 11:57 AM, Roman Mohr <rmohr@redhat.com>
wrote:
On Tue, May 31, 2016 at 10:49 AM, Roman Mohr <rmohr@redhat.com>
wrote:
On Tue, May 31, 2016 at 10:35 AM, Barak Korren <bkorren@redhat.com
wrote: >> That seems to be another issue. When building locally and on travis >> we >> have failing dao tests, not missing libraries. >> >> Further, on jenkins it seems like we are not running the DAO tests >> since 26th of May. >> Wrote a mail to infra list regarding that about an hour ago. > > Those are still running on the old Jenkins, we only created them on > the new one for the new 4.0 branch. > http://jenkins-old.ovirt.org/search/?q=dao
Ok, the failing tests on merged master patches are there. But we are not running tests on gerrit patches currently:
http://jenkins-old.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/
Were they disabled deliberately?
Oh that was the wrong job. So they are enabled:
http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_created/
So maybe the issue is that the CI tests from old and new jenkins are overwriting their pluses and minuses?
> > We are working on moving these tests into check_patch.sh so that
we
> can neutralize environmental influences and stop having to give > theses > tests special treatment. > > -- > Barak Korren > bkorren@redhat.com > RHEV-CI Team
Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--f54savKjS/tSNRaU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/31 12:32, Eyal Edri wrote:
David, can you investigate?
Sure
On May 31, 2016 12:29 PM, "Roman Mohr" <rmohr@redhat.com> wrote: =20
On Tue, May 31, 2016 at 11:21 AM, Eyal Edri <eedri@redhat.com> wrote:
they only run on changes in :
**/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/c= ommon/businessentities/**
**sql **/backend/manager/modules/dal/**
So where are the jobs for for https://gerrit.ovirt.org/#/c/58328/ for instance? They should have been triggered, right?
excluding file **/backend/manager/modules/dal/src/main/resources/bundles/**
On Tue, May 31, 2016 at 12:15 PM, Roman Mohr <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 11:12 AM, Eyal Edri <eedri@redhat.com> wrote:
the dao tests 4.0 are on the new jenkins and they are running:
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merge=
d/
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_creat= ed/
Am I missing somehting here? From my perspective it looks like they are never triggered.
the old one in old jenkins should be deleted.
On Tue, May 31, 2016 at 11:57 AM, Roman Mohr <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 10:49 AM, Roman Mohr <rmohr@redhat.com>
wrote:
> On Tue, May 31, 2016 at 10:35 AM, Barak Korren <bkorren@redhat.= com
> wrote: >>> That seems to be another issue. When building locally and on travis >>> we >>> have failing dao tests, not missing libraries. >>> >>> Further, on jenkins it seems like we are not running the DAO tests >>> since 26th of May. >>> Wrote a mail to infra list regarding that about an hour ago. >> >> Those are still running on the old Jenkins, we only created th= em on >> the new one for the new 4.0 branch. >> http://jenkins-old.ovirt.org/search/?q=3Ddao > > Ok, the failing tests on merged master patches are there. > But we are not running tests on gerrit patches currently: > > > http://jenkins-old.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/ > > Were they disabled deliberately? >
Oh that was the wrong job. So they are enabled:
http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_cre= ated/
So maybe the issue is that the CI tests from old and new jenkins =
are
overwriting their pluses and minuses?
>> >> We are working on moving these tests into check_patch.sh so th= at we >> can neutralize environmental influences and stop having to give >> theses >> tests special treatment. >> >> -- >> Barak Korren >> bkorren@redhat.com >> RHEV-CI Team _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --f54savKjS/tSNRaU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXTVzHAAoJEEBxx+HSYmnDBRoH/j/w4+sZKG320rqAhWSPlEXX 7KRqWiT2D5UasL9bcF3p+yeNMI+QYEm1vdaD6B1eWf1dpaZQvZTeNDLYD106qSb5 l2EBs0mix1TSzAJZT0fGfTKQzIEL39PNCWWh1OOUHPD2uRTigMBNl2PjDDZ20WOJ LjEbPQRVfCEJ2+Eax8cGJPWj6u+ZsuQoVo0+Ej7DEbOpQSI9SfW4JCr5H27mu3uz y1l5NVXTZ53fe/TnLta06KxqZf+bjsQ7OBRCy7AIsnmiQgFfAHkuuHvUe8hfmm7j GV5vE7/HzWla/DwL79P7o8SlUM1DFgyS7u50LD14SIuU+1eghfyahxOjhzgdG6s= =QxtM -----END PGP SIGNATURE----- --f54savKjS/tSNRaU--
--um2V5WpqCyd73IVb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/31 12:32, Eyal Edri wrote:
David, can you investigate? On May 31, 2016 12:29 PM, "Roman Mohr" <rmohr@redhat.com> wrote: =20
On Tue, May 31, 2016 at 11:21 AM, Eyal Edri <eedri@redhat.com> wrote:
they only run on changes in :
**/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/c= ommon/businessentities/**
**sql **/backend/manager/modules/dal/**
So where are the jobs for for https://gerrit.ovirt.org/#/c/58328/ for instance? They should have been triggered, right?
So, as far as I can see, the issue there is that the dao tests that failed = ran on the old jenkins, and finished before the tests on the new jenkins, getti= ng their review value overridden (as they both use the same user). One solution would be to use different gerrit users for each of the jenkins instances, though the best solution imo is to move the jobs to the new jenk= ins (hopefully, as part of the standard ci, work in progress, not sure of the e= ta)
excluding file **/backend/manager/modules/dal/src/main/resources/bundles/**
On Tue, May 31, 2016 at 12:15 PM, Roman Mohr <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 11:12 AM, Eyal Edri <eedri@redhat.com> wrote:
the dao tests 4.0 are on the new jenkins and they are running:
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merge=
d/
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_creat= ed/
Am I missing somehting here? From my perspective it looks like they are never triggered.
the old one in old jenkins should be deleted.
On Tue, May 31, 2016 at 11:57 AM, Roman Mohr <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 10:49 AM, Roman Mohr <rmohr@redhat.com>
wrote:
> On Tue, May 31, 2016 at 10:35 AM, Barak Korren <bkorren@redhat.= com
> wrote: >>> That seems to be another issue. When building locally and on travis >>> we >>> have failing dao tests, not missing libraries. >>> >>> Further, on jenkins it seems like we are not running the DAO tests >>> since 26th of May. >>> Wrote a mail to infra list regarding that about an hour ago. >> >> Those are still running on the old Jenkins, we only created th= em on >> the new one for the new 4.0 branch. >> http://jenkins-old.ovirt.org/search/?q=3Ddao > > Ok, the failing tests on merged master patches are there. > But we are not running tests on gerrit patches currently: > > > http://jenkins-old.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/ > > Were they disabled deliberately? >
Oh that was the wrong job. So they are enabled:
http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_cre= ated/
So maybe the issue is that the CI tests from old and new jenkins =
are
overwriting their pluses and minuses?
>> >> We are working on moving these tests into check_patch.sh so th= at we >> can neutralize environmental influences and stop having to give >> theses >> tests special treatment. >> >> -- >> Barak Korren >> bkorren@redhat.com >> RHEV-CI Team _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --um2V5WpqCyd73IVb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXTWZGAAoJEEBxx+HSYmnD05AIAJh5E43aE5RWwIgvgcXai27Y 70xmFdh+ffgLcwLbT7Zglk64esPVpppy7Mix9o5JrqCYVE1rvrMbtrAp7OfYeG1Q pO8ZfRXzN9MrsCpMimpoVPpAA8WhljbxZiGS6k/gbK0crl19xJhVCzM5WxWhUWj1 tupTAoADQ33iD1RdcPp6nYyVaMz6LQrzg37Z8R81Ohzc5jKoDfQymjBwN9xQu0Dw kEQwTgrGz01Deb5q1TGv/pWU5x2IqIjhpbkn6CRzOvcjl+7lSbRG1MbND0RhoAek qa8PXPMjRyfKlvw7rRbNCU3cfIqesHRJ3KivD3xbHAQD2tplJX3IGcVwHwpfIAo= =R5IT -----END PGP SIGNATURE----- --um2V5WpqCyd73IVb--
It shouldn't happen again since I migrated all dao-tests jobs to the new jenkins. On Tue, May 31, 2016 at 1:24 PM, dcaro <dcaro@redhat.com> wrote:
On 05/31 12:32, Eyal Edri wrote:
David, can you investigate? On May 31, 2016 12:29 PM, "Roman Mohr" <rmohr@redhat.com> wrote:
On Tue, May 31, 2016 at 11:21 AM, Eyal Edri <eedri@redhat.com> wrote:
they only run on changes in :
**/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/**
**sql **/backend/manager/modules/dal/**
So where are the jobs for for https://gerrit.ovirt.org/#/c/58328/ for instance? They should have been triggered, right?
So, as far as I can see, the issue there is that the dao tests that failed ran on the old jenkins, and finished before the tests on the new jenkins, getting their review value overridden (as they both use the same user).
One solution would be to use different gerrit users for each of the jenkins instances, though the best solution imo is to move the jobs to the new jenkins (hopefully, as part of the standard ci, work in progress, not sure of the eta)
excluding file **/backend/manager/modules/dal/src/main/resources/bundles/**
On Tue, May 31, 2016 at 12:15 PM, Roman Mohr <rmohr@redhat.com>
On Tue, May 31, 2016 at 11:12 AM, Eyal Edri <eedri@redhat.com>
wrote:
the dao tests 4.0 are on the new jenkins and they are running:
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/
http://jenkins.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_created/
Am I missing somehting here? From my perspective it looks like they are never triggered.
the old one in old jenkins should be deleted.
On Tue, May 31, 2016 at 11:57 AM, Roman Mohr <rmohr@redhat.com> wrote: > > On Tue, May 31, 2016 at 10:49 AM, Roman Mohr <rmohr@redhat.com> wrote: > > On Tue, May 31, 2016 at 10:35 AM, Barak Korren < bkorren@redhat.com
> > wrote: > >>> That seems to be another issue. When building locally and on travis > >>> we > >>> have failing dao tests, not missing libraries. > >>> > >>> Further, on jenkins it seems like we are not running the DAO tests > >>> since 26th of May. > >>> Wrote a mail to infra list regarding that about an hour ago. > >> > >> Those are still running on the old Jenkins, we only created
wrote: them
on
> >> the new one for the new 4.0 branch. > >> http://jenkins-old.ovirt.org/search/?q=dao > > > > Ok, the failing tests on merged master patches are there. > > But we are not running tests on gerrit patches currently: > > > > > >
http://jenkins-old.ovirt.org/job/ovirt-engine_4.0_dao-unit-tests_merged/
> > > > Were they disabled deliberately? > > > > Oh that was the wrong job. So they are enabled: > > > >
> > So maybe the issue is that the CI tests from old and new jenkins are > overwriting their pluses and minuses? > > >> > >> We are working on moving these tests into check_patch.sh so
http://jenkins-old.ovirt.org/job/ovirt-engine_master_dao-unit-tests_created/ that
we
> >> can neutralize environmental influences and stop having to give > >> theses > >> tests special treatment. > >> > >> -- > >> Barak Korren > >> bkorren@redhat.com > >> RHEV-CI Team > _______________________________________________ > Devel mailing list > Devel@ovirt.org > http://lists.ovirt.org/mailman/listinfo/devel > >
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
participants (2)
-
dcaro -
Eyal Edri