[ https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27648#comment-27648 ] Martin Sivak commented on OVIRT-1154: ------------------------------------- I am not opposed to Gerrit comments, but those need to be part of the message the user gets so we do not have to search for the right syntax. Barak asked me to paste my email about the matter here, so here you go:

Btw, I just found a project that uses whitelist - kubernetes. But they make it very easy for maintainers to accept patches. Check for example this pull request: https://github.com/kubernetes/kubernetes/pull/41119

The idea I like is that the CI will immediately tell me what needs to be done in the comments. No need to search through documentation for the right keyword.

- The bot told the contributor who the relevant maintainers are, computed the list of people with enough permissions and notified them too. And just a comment by maintainer was needed to enable CI for the pull request. - The same for failing tests - they provide the command to retrigger it directly in the message

It all basically boils down to "Do not make me think" approach. Everything that needs to be done is immediately obvious without searching. And that I could accept even with the whitelist enabled.

Improve and automate the jenkins-whitelist mechanism ----------------------------------------------------

Key: OVIRT-1154 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1154 Project: oVirt - virtualization made easy Issue Type: Improvement Components: Jenkins Reporter: Barak Korren Assignee: infra

Right now our white list is based on a text file with email addresses in it. Its kinda silly when we already have lists and groups of users in Gerrit. Some suggestions: * make any members of a project's "maintainers" group automatically white-listed * make a specific group for other white-listed people

-- This message was sent by Atlassian JIRA (v1000.773.3#100032)