Can't merge patches due to unjustified findbugs failure

Hi, Getting inexplicable findbugs failures on a patch: http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/20910/cons... If we know that Jenkins is unstable, maybe we can have it not block merging of patches? Thanks, Lior.

--FhKpTYimqQF2+bfE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11/24, Lior Vernia wrote:
Hi, =20 Getting inexplicable findbugs failures on a patch: =20 http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/20910/c= onsole =20 If we know that Jenkins is unstable, maybe we can have it not block merging of patches?
Patches can be merged anyhow by managers and product leads. Fixing the tests should be considered first priority and part of the develpoment process. So if it's not a critical issue I say we fix the test. I see it started failing today (since build 20910), I'm rerunning on the branch head to see if the issue is already merged. I also see that all the failed jobs that ran on el6-vm05 had the same issue (the unable to get xclass...ArrayIndexOutOfBoundsException). I've taken the slave out as a precaution, I'll rerun your patch after the HEAD to check if it was the slave.
=20 Thanks, Lior. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --FhKpTYimqQF2+bfE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUc0R1AAoJEEBxx+HSYmnDFOsIAINDUfx11BForeH1RfhZ6IRH BFqVSA4flNgpbMKk8Ce24hBdkZSCWI212kdSqbrO437aY4wJG5TXQq+0noEQHSTn IB7Sk/DQ06+wnksnkxzI8zpssqMp8wv8QullmQz/VEntz0jbJbwW8LD++OSQ93/L ytQmvcjOrKaMU7U180Rsz02ht/NjKOcwbWYJi5MJTjpAqhZcjXkDOwxICnE9kQGD 51WjK6fWqZIHQWZgpP0ix9TEnXqMsLP6Uuas9W3g24P4zjncZtcq6GzKEtfPPsOB wV06iO3GSFkVu0blkVg4PmqsXYzAqMQ27J3grK91g4nzvKN/5BP5ohiro8ralXw= =yuni -----END PGP SIGNATURE----- --FhKpTYimqQF2+bfE--

On 24/11/14 16:45, David Caro wrote:
On 11/24, Lior Vernia wrote:
Hi,
Getting inexplicable findbugs failures on a patch:
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/20910/cons...
If we know that Jenkins is unstable, maybe we can have it not block merging of patches?
Patches can be merged anyhow by managers and product leads.
Fixing the tests should be considered first priority and part of the develpoment process.
So if it's not a critical issue I say we fix the test.
I see it started failing today (since build 20910), I'm rerunning on the branch head to see if the issue is already merged.
I also see that all the failed jobs that ran on el6-vm05 had the same issue (the unable to get xclass...ArrayIndexOutOfBoundsException).
I've taken the slave out as a precaution, I'll rerun your patch after the HEAD to check if it was the slave.
Thanks, that did the trick :)
Thanks, Lior. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
participants (2)
-
David Caro
-
Lior Vernia