Fwd: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely
(Sorry, this time to the right address) ---------- Forwarded message ---------- From: Yedidyah Bar David <didi@redhat.com> Date: Sun, Jan 31, 2016 at 1:20 PM Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely To: Jenkins CI <gerrit2@gerrit.ovirt.org> On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2@gerrit.ovirt.org> wrote:
Jenkins CI has posted comments on this change.
Change subject: packaging: rename: Handle storage domains more nicely ......................................................................
Patch Set 1: Continuous-Integration-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/1312/ : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/1410/ : FAILURE
Both of these are pep8: packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:21: E126 continuation line over-indented for hanging indent packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:21: E126 continuation line over-indented for hanging indent
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1004/ : SUCCESS
How come this one passed? Do we have different versions/configuration of pep8 in different OSes? Also note that E126 is ignored by default, see e.g.: https://github.com/PyCQA/pep8/issues/265 https://github.com/PyCQA/pep8/pull/360
-- To view, visit https://gerrit.ovirt.org/52898 To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org> Gerrit-HasComments: No
-- Didi -- Didi
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/1312/ : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/1410/ : FAILURE
Both of these are pep8:
packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:21: E126 continuation line over-indented for hanging indent packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:21: E126 continuation line over-indented for hanging indent
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1004/ : SUCCESS
How come this one passed?
Do we have different versions/configuration of pep8 in different OSes?
If you didn't do anything special, you are probably using PEP8 from the distro repositories, which is different across repos... If you want to use the same pep8 on every distro, you will need to modify check_patch.sh to do that. For example you could make it pull a specific PEP8 version with pip.
Also note that E126 is ignored by default, see e.g.:
https://github.com/PyCQA/pep8/issues/265 https://github.com/PyCQA/pep8/pull/360
This was probably added on F23 but not landed in EL6/7 yey (or will not ever). You can force this my making pep8 used some configuration file in check_patch.sh -- Barak Korren bkorren@redhat.com RHEV-CI Team
--ytoMbUMiTKPMT3hY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02/02 11:45, Yedidyah Bar David wrote:
Jenkins CI has posted comments on this change.
Change subject: packaging: rename: Handle storage domains more nicely ......................................................................
Patch Set 1: Continuous-Integration-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/13= 12/ : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/14= 10/ : FAILURE =20 Both of these are pep8: =20
(Sorry, this time to the right address) =20 =20 ---------- Forwarded message ---------- From: Yedidyah Bar David <didi@redhat.com> Date: Sun, Jan 31, 2016 at 1:20 PM Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely To: Jenkins CI <gerrit2@gerrit.ovirt.org> =20 =20 On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2@gerrit.ovirt.org> w= rote: packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:= 21: E126 continuation line over-indented for hanging indent packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:= 21: E126 continuation line over-indented for hanging indent =20
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1=
004/ : SUCCESS =20 How come this one passed? =20 Do we have different versions/configuration of pep8 in different OSes?
Unless you are explicitly specifying a version of pep8 yes, they probably have different versions for different oses.
=20 Also note that E126 is ignored by default, see e.g.: =20 https://github.com/PyCQA/pep8/issues/265 https://github.com/PyCQA/pep8/pull/360
It's up to the project owners to decide what to test and how, for what I can see the script that runs pep8/pyflakes on the code is under, build/python-check.sh.in, and it was written by abarlev, so maybe you should talk to whomever inherited he's responsabilities (I don't know who that is, sorry, try on devel list)
-- To view, visit https://gerrit.ovirt.org/52898 To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org> Gerrit-HasComments: No
=20 =20 =20 -- Didi =20 =20 --=20 Didi _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --ytoMbUMiTKPMT3hY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWsITTAAoJEEBxx+HSYmnD7FgH/0qpbibdSXb4kwuHyDgj7Hqb Z4VBRs1C2haSE5QZOV8PV9Qi0GrzmVOMy9MrKBL+CLxJLgxbujC6Ti405CX+uw2j c9sFWbz8AlSEGOsvXh+2ZFg+z9/XGdN76gEuVvBLcz/EK/y/UOuEXQca2mvVBeDM FbWR6klFuaOuUQCg1uxL5fZ1OuBwWU/vyQlFwg/CSloghJOntJlrL3QWa4wrEw9I c6BNlO7GsW4++L3p2WssZrVH62B760Wa7MC9KvmzYKuTAXVyW71u5t/M7AriYi1o HpPu+2uVhaZ9MIwpzqSHKsAocdeofZkhqnU9EZOO6ako8iv8qDKeQUDXs/KRlek= =tTxM -----END PGP SIGNATURE----- --ytoMbUMiTKPMT3hY--
On Tue, Feb 2, 2016 at 12:28 PM, David Caro <dcaro@redhat.com> wrote:
On 02/02 11:45, Yedidyah Bar David wrote:
(Sorry, this time to the right address)
---------- Forwarded message ---------- From: Yedidyah Bar David <didi@redhat.com> Date: Sun, Jan 31, 2016 at 1:20 PM Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely To: Jenkins CI <gerrit2@gerrit.ovirt.org>
On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2@gerrit.ovirt.org> wrote:
Jenkins CI has posted comments on this change.
Change subject: packaging: rename: Handle storage domains more nicely ......................................................................
Patch Set 1: Continuous-Integration-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/1312/ : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/1410/ : FAILURE
Both of these are pep8:
packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:21: E126 continuation line over-indented for hanging indent packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:21: E126 continuation line over-indented for hanging indent
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1004/ : SUCCESS
How come this one passed?
Do we have different versions/configuration of pep8 in different OSes?
Unless you are explicitly specifying a version of pep8 yes, they probably have different versions for different oses.
Indeed, and el6 and el7 had old, buggy versions.
Also note that E126 is ignored by default, see e.g.:
https://github.com/PyCQA/pep8/issues/265 https://github.com/PyCQA/pep8/pull/360
It's up to the project owners to decide what to test and how, for what I can see the script that runs pep8/pyflakes on the code is under, build/python-check.sh.in, and it was written by abarlev, so maybe you should talk to whomever inherited he's responsabilities (I don't know who that is, sorry, try on devel list)
For el7 we already had a newer one on [1]. For el6 I built the srpm. Sandro now copied both to ci-tools [2] [3]. FYI and thanks. [1] http://mirror.centos.org/centos/7/virt/x86_64/ovirt-3.6/common/ [2] http://resources.ovirt.org/repos/ci-tools/el6/noarch/ [3] http://resources.ovirt.org/repos/ci-tools/el7/noarch/ -- Didi
--2NLGdgz3UMHa/lqP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02/02 16:08, Yedidyah Bar David wrote:
On Tue, Feb 2, 2016 at 12:28 PM, David Caro <dcaro@redhat.com> wrote:
On 02/02 11:45, Yedidyah Bar David wrote:
(Sorry, this time to the right address)
---------- Forwarded message ---------- From: Yedidyah Bar David <didi@redhat.com> Date: Sun, Jan 31, 2016 at 1:20 PM Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely To: Jenkins CI <gerrit2@gerrit.ovirt.org>
On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2@gerrit.ovirt.org= wrote:
Jenkins CI has posted comments on this change.
Change subject: packaging: rename: Handle storage domains more nicely ....................................................................= =2E.
Patch Set 1: Continuous-Integration-1
Build Failed
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64= /1312/ : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64= /1410/ : FAILURE
Both of these are pep8:
packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:3= 11:21: E126 continuation line over-indented for hanging indent packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:3= 12:21: E126 continuation line over-indented for hanging indent
http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_6=
4/1004/ : SUCCESS
How come this one passed?
Do we have different versions/configuration of pep8 in different OSes?
Unless you are explicitly specifying a version of pep8 yes, they probably have different versions for different oses. =20 Indeed, and el6 and el7 had old, buggy versions. =20
Also note that E126 is ignored by default, see e.g.:
https://github.com/PyCQA/pep8/issues/265 https://github.com/PyCQA/pep8/pull/360
It's up to the project owners to decide what to test and how, for what I can see the script that runs pep8/pyflakes on the code is under, build/python-check.sh.in, and it was written by abarlev, so maybe you should talk to whomever inherited he's responsabilities (I don't know who that is, sorry, try on devel list) =20 For el7 we already had a newer one on [1]. =20 For el6 I built the srpm. =20 Sandro now copied both to ci-tools [2] [3]. FYI and thanks.
Great :)
=20 [1] http://mirror.centos.org/centos/7/virt/x86_64/ovirt-3.6/common/ [2] http://resources.ovirt.org/repos/ci-tools/el6/noarch/ [3] http://resources.ovirt.org/repos/ci-tools/el7/noarch/ =20 --=20 Didi _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --2NLGdgz3UMHa/lqP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWsL1uAAoJEEBxx+HSYmnDlCUIAJAZlKo7U4fzlIn85B8ahjQh D7tjxEMHT9IDu3xXgba77/FwaEV2c1NQxBSWXbHSE50OWkeBe8U8H4LJssXYr/6s h5p1iUzyNcdX21VoGNAyeeR8pxjodNJXZ9mK0I7YKmWkZaABxEGjcyGFKFvdmnGq lXUTL/cdTgxEbv/adskq45LKuDtq9h9edjybd3nkgwEk6/UrbX85X15vZR4nemNx KM5uQmZRpF4TlNcjLHgETGB3SSoB76Za6u0tqVvNcvHVSaqUtWyUcdnMxFRjZbH2 IMQLtfGcHRQoRYULdsra+aPK2sOgV15wqgDVEFAj3XaBem+LEtiM3VeetmhnMVQ= =1Spu -----END PGP SIGNATURE----- --2NLGdgz3UMHa/lqP--
participants (3)
-
Barak Korren -
David Caro -
Yedidyah Bar David