Ehud, can you have a look, please? Thanks. > On 17. 3. 2021, at 12:22, Yedidyah Bar David <didi(a)redhat.com&gt; wrote: > > Hi all, > > We now merged a patch [1] that changes the CI configuration of > ovirt-appliance. In particular, it replaces check-patch and > build-artifacts files under automation/ with new sub-stages. It worked > well when I did 'ci build', before merging, but now, after merging, I > ran [2], and it failed, saying: > > 12:07:07 WARN: Unable to find sh file automation/build-artifacts.sh or > automation/build-artifacts.sh.el8, skipping sh > > I suppose this is due to its definition in jenkins [3], but not sure > how to fix. Perhaps best replace this with an entry in > standard-poll-stage-pipelines.yaml - e.g. [4] (and probably remove > [3])? Something else? If [4], not sure what the implications are > elsewhere. > > Thanks and best regards, > > [1] https://gerrit.ovirt.org/c/ovirt-appliance/+/113555 > > [2] https://jenkins.ovirt.org/job/ovirt-appliance_master_build-artifacts-el8-... > > [3] https://github.com/oVirt/jenkins/blob/master/jobs/confs/projects/ovirt-ap... > > [4] https://gerrit.ovirt.org/c/jenkins/+/113912 > -- > Didi > _______________________________________________ > Infra mailing list -- infra(a)ovirt.org > To unsubscribe send an email to infra-leave(a)ovirt.org > Privacy Statement: https://www.ovirt.org/privacy-policy.html > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ > List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/BWXH2VXIPUN... -- Anton Marchukov Associate Manager - RHV DevOps - Red Hat

On Wed, Mar 17, 2021 at 2:01 PM Ehud Yonasi <eyonasi(a)redhat.com&gt; wrote: > > Hey Didi, > > Note that the `ci build` triggers stdci v2 jobs such as `ovirt-appliance_standard-check-patch` and inside it will build the artifacts. > The other job you mentioned is a v1 job that is less flexible and is looking for the `build-artifacts.sh` script. to fix it we can just remove that job because > you are already using v2. OK. I see you merged my patch, thanks. I now ran the job, let's see if it works.

Would you now remove the old job definition? Would this affect anything else? Publishing, etc.? Thanks and best regards, > > Thanks, > Ehud. > > On Wed, Mar 17, 2021 at 1:50 PM Anton Marchukov <amarchuk(a)redhat.com&gt; wrote: >> >> Ehud, can you have a look, please? >> >> Thanks. >> >> > On 17. 3. 2021, at 12:22, Yedidyah Bar David <didi(a)redhat.com&gt; wrote: >> > >> > Hi all, >> > >> > We now merged a patch [1] that changes the CI configuration of >> > ovirt-appliance. In particular, it replaces check-patch and >> > build-artifacts files under automation/ with new sub-stages. It worked >> > well when I did 'ci build', before merging, but now, after merging, I >> > ran [2], and it failed, saying: >> > >> > 12:07:07 WARN: Unable to find sh file automation/build-artifacts.sh or >> > automation/build-artifacts.sh.el8, skipping sh >> > >> > I suppose this is due to its definition in jenkins [3], but not sure >> > how to fix. Perhaps best replace this with an entry in >> > standard-poll-stage-pipelines.yaml - e.g. [4] (and probably remove >> > [3])? Something else? If [4], not sure what the implications are >> > elsewhere. >> > >> > Thanks and best regards, >> > >> > [1] https://gerrit.ovirt.org/c/ovirt-appliance/+/113555 >> > >> > [2] https://jenkins.ovirt.org/job/ovirt-appliance_master_build-artifacts-el8-... >> > >> > [3] https://github.com/oVirt/jenkins/blob/master/jobs/confs/projects/ovirt-ap... >> > >> > [4] https://gerrit.ovirt.org/c/jenkins/+/113912 >> > -- >> > Didi >> > _______________________________________________ >> > Infra mailing list -- infra(a)ovirt.org >> > To unsubscribe send an email to infra-leave(a)ovirt.org >> > Privacy Statement: https://www.ovirt.org/privacy-policy.html >> > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ >> > List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/BWXH2VXIPUN... >> >> -- >> Anton Marchukov >> Associate Manager - RHV DevOps - Red Hat >> >> >> >> >> >> -- Didi

I've sent a patch for example [1], You need to define the poll stage in order for the poll job to run. [1]: https://gerrit.ovirt.org/c/ovirt-appliance/+/113923

On Wed, Mar 17, 2021 at 3:01 PM Yedidyah Bar David <didi(a)redhat.com&gt; wrote: > > On Wed, Mar 17, 2021 at 2:52 PM Yedidyah Bar David <didi(a)redhat.com&gt; wrote: > > > > On Wed, Mar 17, 2021 at 2:01 PM Ehud Yonasi <eyonasi(a)redhat.com&gt; wrote: > > > > > > Hey Didi, > > > > > > Note that the `ci build` triggers stdci v2 jobs such as `ovirt-appliance_standard-check-patch` and inside it will build the artifacts. > > > The other job you mentioned is a v1 job that is less flexible and is looking for the `build-artifacts.sh` script. to fix it we can just remove that job because > > > you are already using v2. > > > > OK. I see you merged my patch, thanks. I now ran the job, let's see if it works. > > It didn't do anything [1]. It says: > > https://jenkins.ovirt.org/job/ovirt-appliance_master_standard-poll-upstre... > : > > Note:For post-merge runs, only check-merged threads get invoked. > To get build-artifacts threads to run, you need to configure the > branch as a release branch. > > Although I do have this: > > release_branches: > master: ovirt-master > > Any idea? Thanks. > > [1] https://jenkins.ovirt.org/job/ovirt-appliance_master_standard-poll-upstre... > > > > > Would you now remove the old job definition? > > > > Would this affect anything else? Publishing, etc.? > > > > Thanks and best regards, > > > > > > > > Thanks, > > > Ehud. > > > > > > On Wed, Mar 17, 2021 at 1:50 PM Anton Marchukov <amarchuk(a)redhat.com&gt; wrote: > > >> > > >> Ehud, can you have a look, please? > > >> > > >> Thanks. > > >> > > >> > On 17. 3. 2021, at 12:22, Yedidyah Bar David <didi(a)redhat.com&gt; wrote: > > >> > > > >> > Hi all, > > >> > > > >> > We now merged a patch [1] that changes the CI configuration of > > >> > ovirt-appliance. In particular, it replaces check-patch and > > >> > build-artifacts files under automation/ with new sub-stages. It worked > > >> > well when I did 'ci build', before merging, but now, after merging, I > > >> > ran [2], and it failed, saying: > > >> > > > >> > 12:07:07 WARN: Unable to find sh file automation/build-artifacts.sh or > > >> > automation/build-artifacts.sh.el8, skipping sh > > >> > > > >> > I suppose this is due to its definition in jenkins [3], but not sure > > >> > how to fix. Perhaps best replace this with an entry in > > >> > standard-poll-stage-pipelines.yaml - e.g. [4] (and probably remove > > >> > [3])? Something else? If [4], not sure what the implications are > > >> > elsewhere. > > >> > > > >> > Thanks and best regards, > > >> > > > >> > [1] https://gerrit.ovirt.org/c/ovirt-appliance/+/113555 > > >> > > > >> > [2] https://jenkins.ovirt.org/job/ovirt-appliance_master_build-artifacts-el8-... > > >> > > > >> > [3] https://github.com/oVirt/jenkins/blob/master/jobs/confs/projects/ovirt-ap... > > >> > > > >> > [4] https://gerrit.ovirt.org/c/jenkins/+/113912 > > >> > -- > > >> > Didi > > >> > _______________________________________________ > > >> > Infra mailing list -- infra(a)ovirt.org > > >> > To unsubscribe send an email to infra-leave(a)ovirt.org > > >> > Privacy Statement: https://www.ovirt.org/privacy-policy.html > > >> > oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ > > >> > List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/BWXH2VXIPUN... > > >> > > >> -- > > >> Anton Marchukov > > >> Associate Manager - RHV DevOps - Red Hat > > >> > > >> > > >> > > >> > > >> > > >> > > > > > > -- > > Didi > > > > -- > Didi >