Updated Puppet Code for New Resources is Ready for Review
Hello All. Please note that the new puppet code for resources is now ready for review. I have rebased and rejoined everything in proper order here: https://gerrit.ovirt.org/#/q/topic:fb-resources-puppet This should address all feedback I got from previous review, so please go and have a look. This was verified on resources02.phx.ovirt.org via my separate "antontest" environment in foreman. Please do not merge this as we have part of infra (resources01) running on old Fedora and thus when this change is ready to merge I will need to decommission it first. So I will handle merge myself as part of migration effort. Anton. -- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
You can go ahead and merge this as far as I'm concerned. I think its been waiting long enough... On 30 October 2015 at 17:29, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello All.
Please note that the new puppet code for resources is now ready for review. I have rebased and rejoined everything in proper order here:
https://gerrit.ovirt.org/#/q/topic:fb-resources-puppet
This should address all feedback I got from previous review, so please go and have a look. This was verified on resources02.phx.ovirt.org via my separate "antontest" environment in foreman.
Please do not merge this as we have part of infra (resources01) running on old Fedora and thus when this change is ready to merge I will need to decommission it first. So I will handle merge myself as part of migration effort.
Anton.
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Barak Korren bkorren@redhat.com RHEV-CI Team
+1. On Sun, Nov 1, 2015 at 2:15 PM, Barak Korren <bkorren@redhat.com> wrote:
You can go ahead and merge this as far as I'm concerned. I think its been waiting long enough...
On 30 October 2015 at 17:29, Anton Marchukov <amarchuk@redhat.com> wrote:
Hello All.
Please note that the new puppet code for resources is now ready for review. I have rebased and rejoined everything in proper order here:
https://gerrit.ovirt.org/#/q/topic:fb-resources-puppet
This should address all feedback I got from previous review, so please go and have a look. This was verified on resources02.phx.ovirt.org via my separate "antontest" environment in foreman.
Please do not merge this as we have part of infra (resources01) running on old Fedora and thus when this change is ready to merge I will need to decommission it first. So I will handle merge myself as part of migration effort.
Anton.
-- Anton Marchukov Senior Software Engineer - RHEV CI - Red Hat
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Barak Korren bkorren@redhat.com RHEV-CI Team _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Supervisor, RHEV CI EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
participants (3)
-
Anton Marchukov -
Barak Korren -
Eyal Edri