[ https://ovirt-jira.atlassian.net/browse/OVIRT-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41029#comment-41029 ] Yedidyah Bar David commented on OVIRT-3098: ------------------------------------------- On Mon, Jun 21, 2021 at 9:58 PM Eyal Shenitzky <eshenitz@redhat.com> wrote:

+Dusan Fodor

On Mon, 21 Jun 2021 at 13:32, Nir Soffer <nsoffer@redhat.com> wrote:

...

Gerrit hook is wrongly looking for https://bugzilla.redhat.com/ URLs in the commit message, and adding the patch to the bug.

Example patch: https://gerrit.ovirt.org/c/vdsm/+/115339

I had to clean up the bug after the broken hook (see screenshot).

The hook should really look only in the single URL in (one or more) Bug-Url headers:

Bug-Url: https://bugzilla.redhat.com/

I reported this years ago (I think for Related-To:), and I remember we had a patch fixing this issue, but for some reason it was lost.

Nir

See also: https://ovirt-jira.atlassian.net/browse/OVIRT-3075 Best regards, -- Didi

Gerrit hook adds unrelated patches to bugs ------------------------------------------

Key: OVIRT-3098 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-3098 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: Nir Soffer Assignee: infra Attachments: Screenshot from 2021-06-21 13-16-19.png

Gerrit hook is wrongly looking for https://bugzilla.redhat.com/ URLs in the commit message, and adding the patch to the bug. Example patch: https://gerrit.ovirt.org/c/vdsm/+/115339 I had to clean up the bug after the broken hook (see screenshot). The hook should really look only in the single URL in (one or more) Bug-Url headers: Bug-Url: https://bugzilla.redhat.com/ I reported this years ago (I think for Related-To:), and I remember we had a patch fixing this issue, but for some reason it was lost. Nir

-- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100166)