Fix mock_cleanup.sh umount failures ----------------------------------- Key: OVIRT-937 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-937 Project: oVirt - virtualization made easy Issue Type: Bug Components: Jenkins Reporter: Barak Korren Assignee: Barak Korren Cleanup script can log faux failures when trying to umount leftover mock file systems. This happened here: http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/6291/con... Relevant log lines: {code} 18:36:55 + echo 'Found mounted dirs inside the chroot /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661.' 'Trying to umount.' 18:36:55 Found mounted dirs inside the chroot /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661. Trying to umount. 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/proc 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/sys 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/dev/shm 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/dev/pts 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/var/cache/yum 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/home/jenkins/workspace/vdsm_master_check-merged-el7-x86_64/vdsm 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/run/libvirt 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/var/lib/lago 18:36:55 + for mount in '"${mounts[@]}"' 18:36:55 + sudo umount --lazy /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/proc/filesystems 18:36:55 umount: /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/proc/filesystems: mountpoint not found 18:36:55 + echo 'ERROR: Failed to umount /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/proc/filesystems.' 18:36:55 ERROR: Failed to umount /var/lib/mock/epel-7-x86_64-95d9ead9d725499a15a9021ba2fe9831-54661/root/proc/filesystems. 18:36:55 + failed=true 18:36:55 + this_chroot_failed=true {code} We should make the umount loop not fail if the FS its trying to un-mount is not mounted anymore.