Re: [ovirt-devel] Gerrit headers are not added to commits in vdsm repo ---------------------------------------------------------------------- Key: OVIRT-872 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-872 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: eyal edri [Administrator] Assignee: infra I don't see any options to control this from project config, it will require more investigating to see if its a config option or only available via cherry-pick. opening a ticket to track this. On Sun, Nov 27, 2016 at 1:38 PM, Dan Kenigsberg <danken(a)redhat.com&gt; wrote: > On Sun, Nov 27, 2016 at 12:31:21PM +0200, Eyal Edri wrote: > > Not sure I understand what do you mean by Gerrit Headers. > > Can you give examples? > > > > On Fri, Nov 25, 2016 at 4:57 PM, Nir Soffer <nsoffer(a)redhat.com&gt; wrote: > > > > > On Fri, Nov 25, 2016 at 4:45 PM, Tomáš Golembiovský < > tgolembi(a)redhat.com&gt; > > > wrote: > > > > Hi, > > > > > > > > I've noticed that in vdsm repo the merged commits do not contain the > > > > info headers added by Gerrit any more (Reviewed-by/Reviewed-on/etc.) > . > > > > > > > > Is that intentional? If yes, what was the motivation behind this? > > > > > > > > The change seem to have happened about 4 days ago. Sometime between > the > > > > following two commits: > > > > > > > > * 505f5da API: Introduce getQemuImageInfo API. [Maor Lipchuk] > > > > * 1c4a39c protocoldetector: Avoid unneeded getpeername() [Nir > Soffer] > > > > > > We switched vdsm to fast-forward 4 days ago, maybe this was unintended > > > side effect of this change? > > > > > > The gerrit headers are very useful, please add back. > > > https://gerrit.ovirt.org/#/c/66295/ is the last one which had them: > > Reviewed-on: https://gerrit.ovirt.org/66295 > Reviewed-by: Nir Soffer <nsoffer(a)redhat.com&gt; > Continuous-Integration: Jenkins CI > > they are added to the commit message during cherry-pick, and I find them > very useful. > -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)