[VDSM] ipwrapperTests.TestDrvinfo failing on f21 slave, pass on f20 slave
Hi infra, These tests fail on Fedora 21 slave, and pass on Fedora 20 slave. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1888/console - FAIL http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1908/console - PASS Infra: please check the Fedora 21 slave, maybe this is configuration issue? Ido: please check if the tests are valid Generally these tests are not unitests, and should not run for validating unrelated patches. They should move to the functional tests. Thanks, Nir --- 17:56:50 ====================================================================== 17:56:50 ERROR: testBridgeEthtoolDrvinfo (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 121, in setUp 17:56:50 self._unicode_bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'test-\xe3\x83\x88\xe3\x83\x88\xe3\x83\xad']' returned non-zero exit status 1 17:56:50 17:56:50 ====================================================================== 17:56:50 ERROR: testTogglePromisc (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 119, in setUp 17:56:50 self._bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'vdsmtest-O8JmI']' returned non-zero exit status 1 17:56:50 17:56:50 ====================================================================== 17:56:50 ERROR: testUtf8BridgeEthtoolDrvinfo (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 119, in setUp 17:56:50 self._bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'vdsmtest-O8JmI']' returned non-zero exit status 1 17:56:50
More failures on Fedora 21 slave: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1874/console http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1880/console ----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "infra" <infra@ovirt.org> Cc: "devel" <devel@ovirt.org>, "Dan Kenigsberg" <danken@redhat.com>, "Ido Barkan" <ibarkan@redhat.com> Sent: Thursday, May 7, 2015 12:28:14 AM Subject: [VDSM] ipwrapperTests.TestDrvinfo failing on f21 slave, pass on f20 slave
Hi infra,
These tests fail on Fedora 21 slave, and pass on Fedora 20 slave. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1888/console - FAIL http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1908/console - PASS
Infra: please check the Fedora 21 slave, maybe this is configuration issue? Ido: please check if the tests are valid
Generally these tests are not unitests, and should not run for validating unrelated patches. They should move to the functional tests.
Thanks, Nir
---
17:56:50 ====================================================================== 17:56:50 ERROR: testBridgeEthtoolDrvinfo (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 121, in setUp 17:56:50 self._unicode_bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'test-\xe3\x83\x88\xe3\x83\x88\xe3\x83\xad']' returned non-zero exit status 1 17:56:50 17:56:50 ====================================================================== 17:56:50 ERROR: testTogglePromisc (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 119, in setUp 17:56:50 self._bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'vdsmtest-O8JmI']' returned non-zero exit status 1 17:56:50 17:56:50 ====================================================================== 17:56:50 ERROR: testUtf8BridgeEthtoolDrvinfo (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 119, in setUp 17:56:50 self._bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'vdsmtest-O8JmI']' returned non-zero exit status 1 17:56:50
Those tests run on my fedora21. Can ssh to this slave? Thanks, Ido ----- Original Message ----- From: "Nir Soffer" <nsoffer@redhat.com> To: "infra" <infra@ovirt.org> Cc: "devel" <devel@ovirt.org>, "Dan Kenigsberg" <danken@redhat.com>, "Ido Barkan" <ibarkan@redhat.com> Sent: Thursday, May 7, 2015 12:37:04 AM Subject: Re: [VDSM] ipwrapperTests.TestDrvinfo failing on f21 slave, pass on f20 slave More failures on Fedora 21 slave: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1874/console http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1880/console ----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "infra" <infra@ovirt.org> Cc: "devel" <devel@ovirt.org>, "Dan Kenigsberg" <danken@redhat.com>, "Ido Barkan" <ibarkan@redhat.com> Sent: Thursday, May 7, 2015 12:28:14 AM Subject: [VDSM] ipwrapperTests.TestDrvinfo failing on f21 slave, pass on f20 slave
Hi infra,
These tests fail on Fedora 21 slave, and pass on Fedora 20 slave. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1888/console - FAIL http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1908/console - PASS
Infra: please check the Fedora 21 slave, maybe this is configuration issue? Ido: please check if the tests are valid
Generally these tests are not unitests, and should not run for validating unrelated patches. They should move to the functional tests.
Thanks, Nir
---
17:56:50 ====================================================================== 17:56:50 ERROR: testBridgeEthtoolDrvinfo (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 121, in setUp 17:56:50 self._unicode_bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'test-\xe3\x83\x88\xe3\x83\x88\xe3\x83\xad']' returned non-zero exit status 1 17:56:50 17:56:50 ====================================================================== 17:56:50 ERROR: testTogglePromisc (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 119, in setUp 17:56:50 self._bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'vdsmtest-O8JmI']' returned non-zero exit status 1 17:56:50 17:56:50 ====================================================================== 17:56:50 ERROR: testUtf8BridgeEthtoolDrvinfo (ipwrapperTests.TestDrvinfo) 17:56:50 ---------------------------------------------------------------------- 17:56:50 Traceback (most recent call last): 17:56:50 File "/tmp/run/vdsm/tests/testValidation.py", line 105, in wrapper 17:56:50 return f(*args, **kwargs) 17:56:50 File "/tmp/run/vdsm/tests/ipwrapperTests.py", line 119, in setUp 17:56:50 self._bridge.addDevice() 17:56:50 File "/tmp/run/vdsm/tests/tcTests.py", line 65, in addDevice 17:56:50 check_call([EXT_BRCTL, 'addbr', self.devName]) 17:56:50 File "/usr/lib64/python2.7/subprocess.py", line 540, in check_call 17:56:50 raise CalledProcessError(retcode, cmd) 17:56:50 CalledProcessError: Command '['/usr/sbin/brctl', 'addbr', 'vdsmtest-O8JmI']' returned non-zero exit status 1 17:56:50
On Wed, May 06, 2015 at 05:28:14PM -0400, Nir Soffer wrote:
Hi infra,
These tests fail on Fedora 21 slave, and pass on Fedora 20 slave. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1888/console - FAIL http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1908/console - PASS
Infra: please check the Fedora 21 slave, maybe this is configuration issue? Ido: please check if the tests are valid
Generally these tests are not unitests, and should not run for validating unrelated patches. They should move to the functional tests.
Could you explain your assertions? This tests do not require a functioning vdsm. They don't test vdsm's API, so they should not end up in the "functional" directory. The ipwrapperTests tests the ipwrapper unit of vdsm. But in order to do so, they interact with the host system, and attempt to create a bridge. When this setup fails for some reason (I do not know why `brctl addbr vdsmtest-O8JmI` failed) the test ends up in an ERROR state. If we fail to fix this condition ASAP, we catch this failure and skip the test as broken. But I don't think we should thrown it out of the test suite altogether.
----- Original Message -----
From: "Dan Kenigsberg" <danken@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "infra" <infra@ovirt.org>, "devel" <devel@ovirt.org>, "Ido Barkan" <ibarkan@redhat.com> Sent: Thursday, May 7, 2015 12:32:03 PM Subject: Re: [VDSM] ipwrapperTests.TestDrvinfo failing on f21 slave, pass on f20 slave
On Wed, May 06, 2015 at 05:28:14PM -0400, Nir Soffer wrote:
Hi infra,
These tests fail on Fedora 21 slave, and pass on Fedora 20 slave. http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1888/console - FAIL http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1908/console - PASS
Infra: please check the Fedora 21 slave, maybe this is configuration issue? Ido: please check if the tests are valid
Generally these tests are not unitests, and should not run for validating unrelated patches. They should move to the functional tests.
Could you explain your assertions?
This tests do not require a functioning vdsm. They don't test vdsm's API, so they should not end up in the "functional" directory.
The ipwrapperTests tests the ipwrapper unit of vdsm. But in order to do so, they interact with the host system, and attempt to create a bridge. When this setup fails for some reason (I do not know why `brctl addbr vdsmtest-O8JmI` failed) the test ends up in an ERROR state.
If we fail to fix this condition ASAP, we catch this failure and skip the test as broken. But I don't think we should thrown it out of the test suite altogether.
This requires functioning brctl, so this is integration test. This is true for many other tests that should move to the missing integration tests suite. Nir
participants (3)
-
Dan Kenigsberg -
Ido Barkan -
Nir Soffer