On Thu, Oct 17, 2013 at 06:15:57PM -0400, R P Herrold wrote: You are absolutely right that we're lacking in the documentation. Part of it is because we want to change how it's done now, but a short walk through before I go away for a couple of days. First of all, you clone the repo (and you got the correct URL): git clone --recursive git://gerrit.ovirt.org/infra-puppet.git Then you make the changes as you normally would. I recommend creating topic branches. When you've committed (with sign-off), you should submit the patches to gerrit. I highly recommend git-review for this, but you already figured this out for vdsm. Then it should be reviewed. Once it's merged, comes the tricky part. The deployment to production is manual. Trivial, but manual. What I've done, is adding a remote production git remote add production puppet@foreman.ovirt.org:puppet git fetch production # To get the references Then check out the production branch, merge master and push it git checkout production # Should base on production/production git merge master git push I should note that currently only my SSH key is (manually) added to puppet(a)foreman.ovirt.org/~puppet/.ssh/authorized_keys. Since dcaro has +2 permissions, I'd recommend him to add his until we sort out the r10k deployment (See http://gerrit.ovirt.org/19141 for that). For actually writing the patches, I'm afraid we have little to nothing in place to make your life easier. There is no testing environment, no rspec-puppet based unit tests, no rspec-system based system tests. Not even a simple rake task to validate the syntax[1]. What I can recommend you is puppet-lint and puppet parser validate. If you're a vim user, syntastic (https://github.com/scrooloose/syntastic) does this for you if it's available every time you save. If this is lacking any info or something is unclear, please do ask. I should be back monday, but I can't promise how late or if I'll make the meeting. [1]: If you are going to write tests, I did publish a WIP module which has very little classes and should be a good example: https://github.com/ekohl/puppet-profile_foreman

last i understood from investigation done by kiril & apuimedo, it was related to outdates python-nose pkg. which was updated via pip to latest. can you return your test? also, danken as we talked, might worth increasing the timeout or removing unit tests that require fast infra. e. ----- Original Message -----

On Thu, Oct 17, 2013 at 06:15:57PM -0400, R P Herrold wrote: No harm done by you. We experience way too many false test failures. In your case, a timeout on http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5035/ and a missing output file on http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4151 ERROR: testStop (remoteFileHandlerTests.PoolHandlerTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/tests/remoteFileHandlerTests.py", line 69, in testStop procPath)) File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/storage/remoteFileHandler.py", line 184, in callCrabRPCFunction rawLength = self._recvAll(LENGTH_STRUCT_LENGTH, timeout) File "/home/jenkins/workspace/vdsm_unit_tests_gerrit/vdsm/storage/remoteFileHandler.py", line 150, in _recvAll raise Timeout() Timeout Recording test results No test report files were found. Configuration error? Build step 'Publish JUnit test result report' changed build result to FAILURE Finished: FAILURE Why is vdsm_unit_tests_gerrit_el looking for JUnit test result? I do not see this step on the last successful run of http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4139/console