automation@ovirt.org should not change bug to modified when merging into master

Hi infra, When patch is merged into vdsm master, automation@ovirt.org bot is updating the bug status to MODIFIED. This behavior is wrong - it should be modified only when merging into the ovirt-3.5 branch. The current behavior leads to missing fixes in ovirt, and in the next step, in rhev. Example: 1. http://gerrit.ovirt.org/27122 was merged at Jun 25 3:16 PM 2. automation@ovirt.org bot changed https://bugzilla.redhat.com/1071654 to MODIFIED on 2014-06-25 08:16:40 EDT Nir

On Thu, Jul 17, 2014 at 08:07:28AM -0400, Nir Soffer wrote:
Hi infra,
When patch is merged into vdsm master, automation@ovirt.org bot is updating the bug status to MODIFIED.
This behavior is wrong - it should be modified only when merging into the ovirt-3.5 branch.
The current behavior leads to missing fixes in ovirt, and in the next step, in rhev.
Example:
1. http://gerrit.ovirt.org/27122 was merged at Jun 25 3:16 PM 2. automation@ovirt.org bot changed https://bugzilla.redhat.com/1071654 to MODIFIED on 2014-06-25 08:16:40 EDT
Strictly speaking, the move to MODIFIED should depend on the target release. After ovirt-3.5 is branched, the bot should track merges to that branch for 3.5.* bugs.

----- Original Message -----
From: "Dan Kenigsberg" <danken@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com>, dcaro@redhat.com Cc: "infra" <infra@ovirt.org>, "Allon Mureinik" <amureini@redhat.com>, "Sean Cohen" <scohen@redhat.com> Sent: Thursday, July 17, 2014 5:54:05 PM Subject: Re: automation@ovirt.org should not change bug to modified when merging into master
On Thu, Jul 17, 2014 at 08:07:28AM -0400, Nir Soffer wrote:
Hi infra,
When patch is merged into vdsm master, automation@ovirt.org bot is updating the bug status to MODIFIED.
This behavior is wrong - it should be modified only when merging into the ovirt-3.5 branch.
The current behavior leads to missing fixes in ovirt, and in the next step, in rhev.
Example:
1. http://gerrit.ovirt.org/27122 was merged at Jun 25 3:16 PM 2. automation@ovirt.org bot changed https://bugzilla.redhat.com/1071654 to MODIFIED on 2014-06-25 08:16:40 EDT
Strictly speaking, the move to MODIFIED should depend on the target release. After ovirt-3.5 is branched, the bot should track merges to that branch for 3.5.* bugs.
Right - this issue exists only after new release branch is created. I'm not sure how the script can tell this. Nir

On Thu, Jul 17, 2014 at 11:19:05AM -0400, Nir Soffer wrote:
----- Original Message -----
From: "Dan Kenigsberg" <danken@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com>, dcaro@redhat.com Cc: "infra" <infra@ovirt.org>, "Allon Mureinik" <amureini@redhat.com>, "Sean Cohen" <scohen@redhat.com> Sent: Thursday, July 17, 2014 5:54:05 PM Subject: Re: automation@ovirt.org should not change bug to modified when merging into master
On Thu, Jul 17, 2014 at 08:07:28AM -0400, Nir Soffer wrote:
Hi infra,
When patch is merged into vdsm master, automation@ovirt.org bot is updating the bug status to MODIFIED.
This behavior is wrong - it should be modified only when merging into the ovirt-3.5 branch.
The current behavior leads to missing fixes in ovirt, and in the next step, in rhev.
Example:
1. http://gerrit.ovirt.org/27122 was merged at Jun 25 3:16 PM 2. automation@ovirt.org bot changed https://bugzilla.redhat.com/1071654 to MODIFIED on 2014-06-25 08:16:40 EDT
Strictly speaking, the move to MODIFIED should depend on the target release. After ovirt-3.5 is branched, the bot should track merges to that branch for 3.5.* bugs.
Right - this issue exists only after new release branch is created. I'm not sure how the script can tell this.
At least for Vdsm it's simple: if the target release of the bug is x.y.z, move to MODIFIED only on merge to the ovirt-x.y branch. If no such branch exists - a merge to master is enough.

Happens for engine as well. ----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "infra" <infra@ovirt.org> Cc: "Sean Cohen" <scohen@redhat.com> Sent: Thursday, July 17, 2014 3:07:28 PM Subject: automation@ovirt.org should not change bug to modified when merging into master
Hi infra,
When patch is merged into vdsm master, automation@ovirt.org bot is updating the bug status to MODIFIED.
This behavior is wrong - it should be modified only when merging into the ovirt-3.5 branch.
The current behavior leads to missing fixes in ovirt, and in the next step, in rhev.
Example:
1. http://gerrit.ovirt.org/27122 was merged at Jun 25 3:16 PM 2. automation@ovirt.org bot changed https://bugzilla.redhat.com/1071654 to MODIFIED on 2014-06-25 08:16:40 EDT
Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

there is an open ticket on it for infra: https://fedorahosted.org/ovirt/ticket/221 with high priority. eyal. ----- Original Message -----
From: "Yair Zaslavsky" <yzaslavs@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "Sean Cohen" <scohen@redhat.com>, "infra" <infra@ovirt.org> Sent: Friday, July 18, 2014 8:21:10 AM Subject: Re: automation@ovirt.org should not change bug to modified when merging into master
Happens for engine as well.
----- Original Message -----
From: "Nir Soffer" <nsoffer@redhat.com> To: "infra" <infra@ovirt.org> Cc: "Sean Cohen" <scohen@redhat.com> Sent: Thursday, July 17, 2014 3:07:28 PM Subject: automation@ovirt.org should not change bug to modified when merging into master
Hi infra,
When patch is merged into vdsm master, automation@ovirt.org bot is updating the bug status to MODIFIED.
This behavior is wrong - it should be modified only when merging into the ovirt-3.5 branch.
The current behavior leads to missing fixes in ovirt, and in the next step, in rhev.
Example:
1. http://gerrit.ovirt.org/27122 was merged at Jun 25 3:16 PM 2. automation@ovirt.org bot changed https://bugzilla.redhat.com/1071654 to MODIFIED on 2014-06-25 08:16:40 EDT
Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
participants (4)
-
Dan Kenigsberg
-
Eyal Edri
-
Nir Soffer
-
Yair Zaslavsky