[JIRA] (OVIRT-1774) Upstream source collector can fail to push on multi-branch projects

20 Nov 2017

      This is a multi-part message in MIME format...

------------=_1511186815-19288-176
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Barak Korren created OVIRT-1774:
-----------------------------------

             Summary: Upstream source collector can fail to push on multi-branch projects
                 Key: OVIRT-1774
                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1774
             Project: oVirt - virtualization made easy
          Issue Type: Bug
          Components: oVirt CI
            Reporter: Barak Korren
            Assignee: infra

When the upstream source collection code looks for similar patches in order to avoid pushing a new patch, it lookes for patches that contain the same change to the '{{upstream-sources.yaml}}' file, regardless of the branch they may belong to.

The code currently ignores the possibility that similar changes might be required for different branches, in which case different patches may need to be pushed.

The way of detecting similar patches should be changed so that either the branch name is included in the checksum that are used to identify a patch, or the query is limited to patches of the branch being handled.

--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100072)

------------=_1511186815-19288-176
Content-Type: text/html; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

<html><body>
<h3>Barak Korren created OVIRT-1774:</h3>
<pre>   Summary: Upstream source collector can fail to push on multi-branch projects
       Key: OVIRT-1774
       URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1774
   Project: oVirt - virtualization made easy
Issue Type: Bug
Components: oVirt CI
  Reporter: Barak Korren
  Assignee: infra</pre>
<p>When the upstream source collection code looks for similar patches in order to avoid pushing a new patch, it lookes for patches that contain the same change to the ‘{{upstream-sources.yaml}}’ file, regardless of the branch they may belong to.</p>
<p>The code currently ignores the possibility that similar changes might be required for different branches, in which case different patches may need to be pushed.</p>
<p>The way of detecting similar patches should be changed so that either the branch name is included in the checksum that are used to identify a patch, or the query is limited to patches of the branch being handled.</p>
<p>— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100072)</p>

<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=i5TMWGV99amJbNxJpSp2-2BCmpYLyzY..." alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body></html>

------------=_1511186815-19288-176--

Barak Korren (oVirt JIRA)

tags

participants (1)