--=-UJLgURkJ4g/FxrgmKpUx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Am Mittwoch, den 29.01.2014, 22:00 +0200 schrieb Itamar Heim:
On 01/28/2014 10:05 PM, David Caro wrote:
> El mar 28 ene 2014 18:12:14 CET, Fabian Deutsch escribi=C3=B3:
>> Hey,
>>
>> is it new that gerrit requires commits to have the SIgned-Off-By strin=
g
>> in the commit msg?
>>
>> Thanks
>> fabian
>>
>>
>> _______________________________________________
>> Infra mailing list
>> Infra(a)ovirt.org
>>
http://lists.ovirt.org/mailman/listinfo/infra
>
> Which project are you referring to?
>
> As far as I remember most of the projects required it and some did not.
> I don't remember changing it though, so the projects that did not
> require it should haven't started requiring them. Tell me the project
> you are referring too and I'll take a look.
=20
I'm pretty sure all projects required that since day 1.
Yes.
It was my missunderstanding.
The gerrit rule checks is not just chekcing the presence of the line but
also that this line matches either the submitter or the author.
The patch I was looking at, had a Signed-Off-By line which differed from
the author.
- fabian
=20
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>
> Email: dcaro(a)redhat.com
> Web:
www.redhat.com
> RHT Global #: 82-62605
>
>
>
> _______________________________________________
> Infra mailing list
> Infra(a)ovirt.org
>
http://lists.ovirt.org/mailman/listinfo/infra
>
=20
--=-UJLgURkJ4g/FxrgmKpUx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
iQIcBAABAgAGBQJS8fXNAAoJEC9+uOgSHVGUgcAQAJZ1XcZjME7ZhgoupgEBa5YA
xxQIMVbBvrjAfOTsA2dyHybe0dNZdwG42/VWeRHN8RBDe/Oz0ewufMzfP/QwCTxP
bvcTe91xFBxT9D9jOrsQNgAf53xiwiGPKFof9l1tF+qxNKlnunp+c1QPoyjRF1Hu
UDRHmk0Vgr8TVHKly44/EU3YOXC3no6kuS1qiYQtBEMUNK+/1BpatcDXaobJE5hd
8+QJAO/Qg1UD0jWXrYBKhEax0n2Mt7iKDmS0d4zgWMdLW7VzetmhejIgCiuzH8Xw
chZ96HGuVDGFixJEm0uZLK5jlNB9ZzqkjLjM1XVt+EF2tehcBpbU1ox78BQTr7Lg
1ojJ5JGTf+P+o9EgN5u+YVr5+bD0JNwSvQ+s+QSSwu9CrUH2ox6KmRs9/9DOC0oA
Pzd2ClIvbemdmdrJ1TIZdsCscbs9J4XnxtCnHg/nAzDJ8I92lu/eUkTmxh1KyOqg
OY1oBoSu+Iev9gxtdbn+UX2PT3GNYeF/ntiSIUo0qsutp9zYnfQwcllIynxsK+AB
q/gGqQqyIBdLQJEj5NMmoP10EaVg9yUExb0io53dwR8STK7r3vbbMmf08ZIGpLat
JulzIGPOyzSOLzpjLSba0OaN5Abgt91AnTTArk/UT6+fI4NGdtqXsXA9a6bNI7b1
kdfhyWyOGLzyfKTIQ0cL
=2SVD
-----END PGP SIGNATURE-----
--=-UJLgURkJ4g/FxrgmKpUx--