Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc. Thoughts ? Thanks, Kiril Nesenko Red Hat, Inc. www.redhat.com
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1, this has been brought up in the past and i think is important for growing the infra and our ability to run more complex scripts and jobs.
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On Tue, Mar 05, 2013 at 05:29:28AM -0500, Kiril Nesenko wrote:
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1! Few minutes ago I've failed to find the code for vdsm_verify_error_codes so I can understand what's broken in http://jenkins.ovirt.org/view/vdsm/job/vdsm_verify_error_codes/84/console having a `git blame` would make this much easier.
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1 great idea
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Itamar, Can you create 'jenkins' repo for us in gerrit.ovirt.org ? Thanks, Kiril Nesenko Red Hat, Inc. www.redhat.com ----- Original Message -----
From: "Ohad Basan" <obasan@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 1:14:38 PM Subject: Re: New git repo for jenkins
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1 great idea
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On 05/03/2013 14:02, Kiril Nesenko wrote:
Itamar, Can you create 'jenkins' repo for us in gerrit.ovirt.org ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
----- Original Message -----
From: "Ohad Basan" <obasan@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 1:14:38 PM Subject: Re: New git repo for jenkins
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1 great idea
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
who would be its maintainers?
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 2:05:30 PM Subject: Re: New git repo for jenkins
On 05/03/2013 14:02, Kiril Nesenko wrote:
Itamar, Can you create 'jenkins' repo for us in gerrit.ovirt.org ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
----- Original Message -----
From: "Ohad Basan" <obasan@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 1:14:38 PM Subject: Re: New git repo for jenkins
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1 great idea
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
who would be its maintainers?
i propose myself and dcaro for starts since we are the most active maintainers for jenkins jobs code currently. i believe someone from ovirt-node (mburns or fabiand) will also need +2 permissions.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On 05/03/2013 14:07, Eyal Edri wrote:
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 2:05:30 PM Subject: Re: New git repo for jenkins
On 05/03/2013 14:02, Kiril Nesenko wrote:
Itamar, Can you create 'jenkins' repo for us in gerrit.ovirt.org ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
----- Original Message -----
From: "Ohad Basan" <obasan@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 1:14:38 PM Subject: Re: New git repo for jenkins
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1 great idea
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
who would be its maintainers?
i propose myself and dcaro for starts since we are the most active maintainers for jenkins jobs code currently. i believe someone from ovirt-node (mburns or fabiand) will also need +2 permissions.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
done. added eedri. did not find dcaro in gerrit users. waiting on feedback from ovirt-node folks.
On 03/05/2013 07:11 AM, Itamar Heim wrote:
On 05/03/2013 14:07, Eyal Edri wrote:
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 2:05:30 PM Subject: Re: New git repo for jenkins
On 05/03/2013 14:02, Kiril Nesenko wrote:
Itamar, Can you create 'jenkins' repo for us in gerrit.ovirt.org ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
----- Original Message -----
From: "Ohad Basan" <obasan@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 1:14:38 PM Subject: Re: New git repo for jenkins
----- Original Message -----
From: "Kiril Nesenko" <kiril@redhat.com> To: infra@ovirt.org Sent: Tuesday, March 5, 2013 12:29:28 PM Subject: New git repo for jenkins
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Thoughts ?
+1 great idea
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
who would be its maintainers?
i propose myself and dcaro for starts since we are the most active maintainers for jenkins jobs code currently. i believe someone from ovirt-node (mburns or fabiand) will also need +2 permissions.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
done. added eedri. did not find dcaro in gerrit users. waiting on feedback from ovirt-node folks.
Fabian probably makes the most sense currently. Mike
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On 03/06/2013 01:57 PM, Mike Burns wrote:
On 03/05/2013 07:11 AM, Itamar Heim wrote:
On 05/03/2013 14:07, Eyal Edri wrote:
----- Original Message -----
From: "Itamar Heim" <iheim@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 2:05:30 PM Subject: Re: New git repo for jenkins
On 05/03/2013 14:02, Kiril Nesenko wrote:
Itamar, Can you create 'jenkins' repo for us in gerrit.ovirt.org ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
----- Original Message -----
From: "Ohad Basan" <obasan@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Tuesday, March 5, 2013 1:14:38 PM Subject: Re: New git repo for jenkins
----- Original Message ----- > From: "Kiril Nesenko" <kiril@redhat.com> > To: infra@ovirt.org > Sent: Tuesday, March 5, 2013 12:29:28 PM > Subject: New git repo for jenkins > > Hi all, > I think that we need to create new git repo for jenkins in our > gerrit. > This git will store jenkins jobs configuration, scripts etc. > > Thoughts ?
+1 great idea
> > Thanks, > > Kiril Nesenko > Red Hat, Inc. > > www.redhat.com > > _______________________________________________ > Infra mailing list > Infra@ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
who would be its maintainers?
i propose myself and dcaro for starts since we are the most active maintainers for jenkins jobs code currently. i believe someone from ovirt-node (mburns or fabiand) will also need +2 permissions.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
done. added eedri. did not find dcaro in gerrit users. waiting on feedback from ovirt-node folks.
Fabian probably makes the most sense currently.
added
On 03/05/2013 05:29 AM, Kiril Nesenko wrote:
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Not opposed, but what does this do for creating or changing existing jobs? Do we have to do it outside of jenkins? Do we simply make changes in a git checkout, submit them, then they get pushed live automatically? IOW, I think we need to map out exactly how things are supposed to get updated. I don't think we want people to have to change things in 3 different places. We'll end up with some changes in git that aren't in the live jenkins, some that aren't in git, but are live. Also, what about new job development? Is that done through jenkins and then somehow exported into the git repo? New jobs can take many iterations to get *right*. I know I haven't been involved, but was something like this[1] discussed or evaluated? [1] https://wiki.jenkins-ci.org/display/JENKINS/JobConfigHistory+Plugin Mike
Thoughts ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
----- Original Message -----
From: "Mike Burns" <mburns@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Wednesday, March 6, 2013 2:07:35 PM Subject: Re: New git repo for jenkins
On 03/05/2013 05:29 AM, Kiril Nesenko wrote:
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Not opposed, but what does this do for creating or changing existing jobs? Do we have to do it outside of jenkins? Do we simply make changes in a git checkout, submit them, then they get pushed live automatically?
Let me try to explain. Currently the status is all job logic is written inside the job itself, this is bad practise, for a few reasons: 1. no code review (job configuration is also only viewable and accessible to jenkins power-users/admins, not very "open source" approach) 2. difficult to include usage of files (answer file for example for automating engine-setup) 3. backup of code and revisions (sure there is the job config-history but that's really for troubleshooting the restoring jobs) 4. writing long complex code in bash/python inside a textbox is error prone and not convenient. I have experience from the past 2 years of writing code for jenkins jobs that got complex and longer as the product evolved. today i use even more than one repository for running jobs in jenkins. the proposed change is to keep all code inside a git repo instead just inside jenkins jobs. it doesn't mean that every job that has 2-3 lines of code should go into the git, it means we have a choice, if the code gets too complex (like running engine-setup + engine-upgrade) then we can use git as the source for the code. I intend to add some of the existing jobs that runs complex code into it, but not all of them. that's up to the job maintainer to decide.
IOW, I think we need to map out exactly how things are supposed to get updated. I don't think we want people to have to change things in 3 different places. We'll end up with some changes in git that aren't in the live jenkins, some that aren't in git, but are live.
Also, what about new job development? Is that done through jenkins and then somehow exported into the git repo? New jobs can take many iterations to get *right*.
the way to use it in a job is by using the 'multiple scm plugin' which allows you to listen to more than one git repo for a job. you can see an example in the new setup+upgrade job knesenso is building now http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/con...
I know I haven't been involved, but was something like this[1] discussed or evaluated?
[1] https://wiki.jenkins-ci.org/display/JENKINS/JobConfigHistory+Plugin
as i mentioned, this plugin is good mainly for keeping track on who made change
Mike
Thoughts ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On 03/06/2013 08:54 AM, Eyal Edri wrote:
----- Original Message -----
From: "Mike Burns" <mburns@redhat.com> To: "Kiril Nesenko" <kiril@redhat.com> Cc: infra@ovirt.org Sent: Wednesday, March 6, 2013 2:07:35 PM Subject: Re: New git repo for jenkins
On 03/05/2013 05:29 AM, Kiril Nesenko wrote:
Hi all, I think that we need to create new git repo for jenkins in our gerrit. This git will store jenkins jobs configuration, scripts etc.
Not opposed, but what does this do for creating or changing existing jobs? Do we have to do it outside of jenkins? Do we simply make changes in a git checkout, submit them, then they get pushed live automatically?
Let me try to explain. Currently the status is all job logic is written inside the job itself, this is bad practise, for a few reasons:
Not all, but most (ovirt-node-iso* jobs runs a script file in it's source repository). The logic in the jenkins job is simply clean up and run.
1. no code review (job configuration is also only viewable and accessible to jenkins power-users/admins, not very "open source" approach)
Agreed, though we can easily make the code read-only to non-power-users.
2. difficult to include usage of files (answer file for example for automating engine-setup)
I haven't encountered this issue. I've had jobs before (though not in upstream oVirt) that pulled files from other jobs for this purpose. For example, a job that generates a file like "releases.txt" that contains mappings for something like "FDEVEL=19" FRELEASED=18", etc. which are then sourced in the other job
3. backup of code and revisions (sure there is the job config-history but that's really for troubleshooting the restoring jobs)
4. writing long complex code in bash/python inside a textbox is error prone and not convenient.
I agree about writing code in a textbox like that, it's not ideal. I generally copy it out, edit it in an editor of my choice, then copy it back in.
I have experience from the past 2 years of writing code for jenkins jobs that got complex and longer as the product evolved. today i use even more than one repository for running jobs in jenkins.
the proposed change is to keep all code inside a git repo instead just inside jenkins jobs. it doesn't mean that every job that has 2-3 lines of code should go into the git, it means we have a choice, if the code gets too complex (like running engine-setup + engine-upgrade) then we can use git as the source for the code.
OK, I think that's the right choice. I expect many jobs are simple automake builds that do thinks like: ./autogen make make install make rpms maybe with some slight changes. If there are more complex jobs, then yes, moving the code into something like git is probably worthwhile. It might not be necessary for ovirt-node to have a maintainer on the git repo though. I think our jobs are relatively simple enough to not need it.
I intend to add some of the existing jobs that runs complex code into it, but not all of them. that's up to the job maintainer to decide.
IOW, I think we need to map out exactly how things are supposed to get updated. I don't think we want people to have to change things in 3 different places. We'll end up with some changes in git that aren't in the live jenkins, some that aren't in git, but are live.
Also, what about new job development? Is that done through jenkins and then somehow exported into the git repo? New jobs can take many iterations to get *right*.
the way to use it in a job is by using the 'multiple scm plugin' which allows you to listen to more than one git repo for a job. you can see an example in the new setup+upgrade job knesenso is building now http://jenkins.ovirt.org/job/ovirt_engine_upgrade_stable_32_to_latest_32/con...
OK, I can see how that works. I hadn't tried it previously.
I know I haven't been involved, but was something like this[1] discussed or evaluated?
[1] https://wiki.jenkins-ci.org/display/JENKINS/JobConfigHistory+Plugin
as i mentioned, this plugin is good mainly for keeping track on who made change
OK, I haven't used it, was just making sure we weren't re-inventing the wheel.
Mike
Thoughts ?
Thanks,
Kiril Nesenko Red Hat, Inc.
www.redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FKKPEQDNDPXIAGVBHRER Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/06/2013 06:14 AM, Mike Burns wrote:
I agree about writing code in a textbox like that, it's not ideal. I generally copy it out, edit it in an editor of my choice, then copy it back in.
As a side-note, I highly recommend this plug-in for Firefox: https://addons.mozilla.org/en-us/firefox/addon/its-all-text/ It puts an (edit) button beside an HTML TEXTAREA field. Clicking the button opens your favorite text editor with a temp file. Saving to the temp file updates the TEXTAREA (with a visual cue). I started using it years ago to save sanity when doing wiki work. The temp file is a bonus, as it is usually still present on your filesystem after a browser crash. - Karsten --=20 Karsten 'quaid' Wade, Sr. Analyst - Community Growth http://TheOpenSourceWay.org .^\ http://community.redhat.com @quaid (identi.ca/twitter/IRC) \v' gpg: AD0E0C41 ------enig2FKKPEQDNDPXIAGVBHRER Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iD8DBQFRN+tI2ZIOBq0ODEERArUAAJ0Ry+0+yYoN1cMEHOv9cQ+9OB43IwCg0atS Hqlyjs5QAnM7eId/erAu4GE= =B05j -----END PGP SIGNATURE----- ------enig2FKKPEQDNDPXIAGVBHRER--
----- Original Message -----
From: "Karsten 'quaid' Wade" <kwade@redhat.com> To: infra@ovirt.org Sent: Thursday, March 7, 2013 3:20:08 AM Subject: Re: New git repo for jenkins
On 03/06/2013 06:14 AM, Mike Burns wrote:
I agree about writing code in a textbox like that, it's not ideal. I generally copy it out, edit it in an editor of my choice, then copy it back in.
As a side-note, I highly recommend this plug-in for Firefox:
https://addons.mozilla.org/en-us/firefox/addon/its-all-text/
It puts an (edit) button beside an HTML TEXTAREA field. Clicking the button opens your favorite text editor with a temp file. Saving to the temp file updates the TEXTAREA (with a visual cue).
I started using it years ago to save sanity when doing wiki work. The temp file is a bonus, as it is usually still present on your filesystem after a browser crash.
+10! - really nice plugin :).. thanks for the tip.
- Karsten -- Karsten 'quaid' Wade, Sr. Analyst - Community Growth http://TheOpenSourceWay.org .^\ http://community.redhat.com @quaid (identi.ca/twitter/IRC) \v' gpg: AD0E0C41
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
participants (7)
-
Dan Kenigsberg -
Eyal Edri -
Itamar Heim -
Karsten 'quaid' Wade -
Kiril Nesenko -
Mike Burns -
Ohad Basan